Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only coinbase output features may have metadata set, and is of limited size; ref #4908 #4960

Conversation

agubarev
Copy link
Contributor

Description

Added validation to OutputFeatures which, for now, makes sure that only coinbase output features may have metadata set.

Motivation and Context

Remove Metadata from Output features: metadata is a remnant of the previous DAN implementation. It should be removed from output features

#4908

How Has This Been Tested?

unit tests

leet4tari and others added 2 commits November 25, 2022 11:58
Description
Expose iOS libwallet individually - universal / x86-64 / aarch64

Motivation and Context
Give developers an option for accessing each iOS architecture individually or as the combined universal library.

How Has This Been Tested?
Build locally in fork and all libs accessible
/// This function will check all stxo to ensure that feature flags where followed
pub fn check_stxo_rules(&self, height: u64) -> Result<(), TransactionError> {
pub fn check_output_features(&self, max_coinbase_metadata_size: usize) -> Result<(), TransactionError> {
for output in self.outputs() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit(perf): Rather than looping each time in the validation helper, reuse the loop and call this with the output.

image

@stringhandler stringhandler merged commit 22b1330 into tari-project:development Nov 25, 2022
agubarev added a commit that referenced this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants