fix: update message and signature key types #5064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
comms-keys-update
branch
from
b4f3eb9
to
4a6c68b
Compare
stringhandler
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates communications message and signature keys to use the new
HiddenandSafeArraydesigns. Minor refactoring for clarity of design intent.Motivation and Context
Communications messages are encrypted using the
ChaCha20unauthenticated stream cipher, and signatures are encrypted using theChaCha20-Poly1305authenticated stream cipher. However, the keys used for these purposes are defined using zeroize-on-dropGenericArraytypes; further, the hash derivation of the keys results in copies left in memory.This work updates the key types to use the new
HiddenandSafeArraydesigns. They are renamed to reflect their specific purposes, instantiated in place to reduce in-memory copies, and associated functions are also renamed to make their intent more clear.How Has This Been Tested?
Existing tests pass.