feat!: update Argon2 parameters
#5140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CjS77
added
A-security
AaronFeickert
force-pushed
the
update-argon2-params
branch
from
52a8f82
to
aec0fdd
Compare
stringhandler
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
Argon2parameters.Closes issue 5139.
Motivation and Context
A recent update to the OWASP recommendations for
Argon2password-based key derivation means the codebase is out of date.This PR updates all
Argon2parameters to meet this standard. While there are no particularly concerning risks to users with the older standard, it's a matter of good practice to keep these updated where feasible.Note that this PR does not introduce any kind of key migration, so this change is...
How Has This Been Tested?
Existing tests pass.
BREAKING CHANGE: Renders all previous
Argon2-derived keys invalid.