Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add igor faucet #5281

Merged
merged 3 commits into from
Apr 5, 2023
Merged

feat!: add igor faucet #5281

merged 3 commits into from
Apr 5, 2023

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented Mar 30, 2023 •
edited
Loading

Description

  • Updated the igor genesis block to contain a faucet with revealed values
  • Added a new range-proof option for the genesis block sanity test

Motivation and Context

  • Evaluating faucet with revealed values

How Has This Been Tested?

  • Unit test demonstrating the range proof for each output in the faucet
  • Performed system-level testing to demonstrate that the igor blockchain works properly - 2x base nodes, 2x wallets, 1x SHA3 miner, 1x merge mining proxy, 1x XMRig miner.

What process can a PR reviewer use to test or verify this change?

Perform system-level testing

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - New genesis block.

BREAKING CHANGE: The chain has to be restarted - delete the blockchain database and resync the chain

@ghpbot-tari-project ghpbot-tari-project added CR-too_long Changes Requested - Your PR is too long CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Mar 30, 2023
SWvheerden
SWvheerden reviewed Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just have a few nits

base_layer/core/src/consensus/consensus_constants.rs Outdated Show resolved Hide resolved
base_layer/core/src/consensus/consensus_constants.rs Outdated Show resolved Hide resolved
base_layer/core/src/blocks/genesis_block.rs Outdated Show resolved Hide resolved
@hansieodendaal hansieodendaal changed the title feat!: add igor faucet feat!: [wip] add igor faucet Apr 3, 2023
@ghpbot-tari-project ghpbot-tari-project added the P-conflicts Process - The PR has merge conflicts that need to be resolved label Apr 3, 2023
@ghpbot-tari-project ghpbot-tari-project removed the P-conflicts Process - The PR has merge conflicts that need to be resolved label Apr 3, 2023
@hansieodendaal
Add igor faucet
b0da222 
Updated the igor genesis block to contain a faucet
@hansieodendaal hansieodendaal changed the title feat!: [wip] add igor faucet feat!: add igor faucet Apr 4, 2023
@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Apr 4, 2023
@SWvheerden SWvheerden merged commit bfc92fd into tari-project:development Apr 5, 2023
@SWvheerden SWvheerden mentioned this pull request Apr 5, 2023
Merged
SWvheerden added a commit that referenced this pull request Apr 5, 2023
@SWvheerden
chore(version): v0.49.0-pre.6 (#5292)
b6a93ee 
##
[0.49.0-pre.6](v0.49.0-pre.5...v0.49.0-pre.6)
(2023-04-05)


### ⚠ BREAKING CHANGES

* move key manager service to key_manager (5284)
* add igor faucet (5281)
* reset dates for networks (5283)

### Features

* add igor faucet
([5281](#5281))
([bfc92fd](bfc92fd))
* added auxiliary callback to push base node state changes
[5109](#5109)
([#5257](#5257))
([b7f7d31](b7f7d31))
* move key manager service to key_manager
([5284](#5284))
([d50ed02](d50ed02))
* reset dates for networks
([5283](#5283))
([d6342a4](d6342a4))


### Bug Fixes

* resize transaction tab windows
([5290](#5290))
([bd95a85](bd95a85)),
closes [#4942](#4942)
[#5289](#5289)
[#12365](https://github.com/tari-project/tari/issues/12365)
@hansieodendaal hansieodendaal deleted the ho_igor_faucet branch April 12, 2023 04:59
@AaronFeickert AaronFeickert mentioned this pull request Apr 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWvheerden SWvheerden SWvheerden approved these changes

@stringhandler stringhandler Awaiting requested review from stringhandler

Assignees
No one assigned
Labels
CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. CR-too_long Changes Requested - Your PR is too long P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hansieodendaal @SWvheerden @ghpbot-tari-project @stringhandler