feat!: change signature construction to allow better HW support #5282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
changed the title
ghpbot-tari-project
added
P-acks_required
SWvheerden
added
A-base_node
AaronFeickert
requested changes
Mar 30, 2023
base_layer/core/src/transactions/transaction_components/transaction_input.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/transactions/transaction_components/transaction_kernel.rs
Show resolved
Hide resolved
base_layer/core/src/transactions/transaction_components/transaction_output.rs
Show resolved
Hide resolved
|
The reason we do not see tests updated is that the signatures are generated using the |
SWvheerden
force-pushed
the
sw_change_signatures
branch
from
140802e
to
873af53
Compare
4 tasks
CjS77
added a commit
that referenced
this pull request
Apr 4, 2023
Description --- Resets the dates for the following networks: Esmeralda: Today Nextnet: April 14th Stagenet: Jun 14 Motivation and Context --- For Nextnet and Stagenet these are the dates when these changes come into effect. Esmeralda had a new Gen block as of PR #5282 How Has This Been Tested? --- Unit tests What process can a PR reviewer use to test or verify this change? --- Breaking Changes --- - [x] None - [x] Requires data directory on base node to be deleted - [x] Requires hard fork - [x] Other - Please specify New Gen block, requires network reset <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> Co-authored-by: Cayle Sharrock <CjS77@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the challenges of all signatures to not be
Hash(Key||Nonce||Feat_1||Feat_2||..||Feat_x)but ratherHash(Key||Nonce||Hash(Feat_1||Feat_2||..||Feat_x))Adds the version to the kernel signature as this is currently not checked.
Motivation and Context
This is done because hardware devices need to sign all the data they need to be sent over to the hardware device to be signed. If we have to send all the features over this becomes quite significant in bytes. This is now changed to only send the
messagefield as a single 32-byte array and this still comments to all the features.The kernel version is technically malleable as the version is not committed to in the signature, this is now fixed.
How Has This Been Tested?
All tests pass
What process can a PR reviewer use to test or verify this change?
Make sure all chain signatures are changed.
Adds version to Kernel signature
Breaking Changes
Change all chain signature challenges: Kernel, Script, Metadata
Complete chain reset.
BREAKING CHANGE: Complete chain reset