Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix rpc transaction conversion #5304

Merged

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented Apr 11, 2023

Description

Fixed RPC transaction proto conversion

Motivation and Context

With the RPC conversion minimum_value_promise was zeroed instead of assigned
See #5295

How Has This Been Tested?

What process can a PR reviewer use to test or verify this change?

Run a system-level test to submit a transaction via gRPC to a base node where an output has minimum_value_promise != 0 and then mine the transaction

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Fixed RPC transaction proto conversion as minimum_value_promise was zeroed
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Apr 11, 2023
SWvheerden
SWvheerden previously approved these changes Apr 11, 2023
@@ -259,7 +259,7 @@ impl TryFrom<proto::types::TransactionOutput> for TransactionOutput {

let encrypted_value = EncryptedValue::from_bytes(&output.encrypted_value).map_err(|err| err.to_string())?;

let minimum_value_promise = MicroTari::zero();
let minimum_value_promise = output.minimum_value_promise.into();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

man these defaults...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yip

@ghpbot-tari-project ghpbot-tari-project removed P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Apr 11, 2023
@SWvheerden SWvheerden merged commit 344040a into tari-project:development Apr 11, 2023
@hansieodendaal hansieodendaal deleted the ho_fix_rpc_tx_conversion branch April 12, 2023 04:58
SWvheerden added a commit that referenced this pull request Apr 12, 2023
##
[0.50.0-pre.0](v0.49.0-pre.6...v0.50.0-pre.0)
(2023-04-12)


### ⚠ BREAKING CHANGES

* add paging to utxo stream request (5302)

### Features

* add extended mask recovery
([5301](#5301))
([23d882e](23d882e))
* add network name to data path and --network flag to the miners
([5291](#5291))
([1f04beb](1f04beb))
* add other code template types
([5242](#5242))
([93e5e85](93e5e85))
* add paging to utxo stream request
([5302](#5302))
([3540309](3540309))
* add wallet daemon config
([5311](#5311))
([30419cf](30419cf))
* define different network defaults for bins
([5307](#5307))
([2f5d498](2f5d498))
* feature gates
([5287](#5287))
([72c19dc](72c19dc))
* fix rpc transaction conversion
([5304](#5304))
([344040a](344040a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants