-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: chat ffi #5349
Merged
Merged
feat: chat ffi #5349
Commits on Apr 26, 2023
-
Extract chat client from integration tests
If possible I'll use a common client for FFI so moving the client from the testing suite into the contacts crate makes it more available.
Configuration menu - View commit details
-
Copy full SHA for 852ea15 - Browse repository at this point
Copy the full SHA 852ea15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1648b4c - Browse repository at this point
Copy the full SHA 1648b4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7305fd - Browse repository at this point
Copy the full SHA e7305fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for e52ea5c - Browse repository at this point
Copy the full SHA e52ea5cView commit details -
Treat all chat clients the same in cucumber
Whether FFI or native client treat them the same to reduce duplication of similar functions.
Configuration menu - View commit details
-
Copy full SHA for 20c3899 - Browse repository at this point
Copy the full SHA 20c3899View commit details -
Configuration menu - View commit details
-
Copy full SHA for 929c366 - Browse repository at this point
Copy the full SHA 929c366View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1f1bd8 - Browse repository at this point
Copy the full SHA a1f1bd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 962bd4c - Browse repository at this point
Copy the full SHA 962bd4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09b442d - Browse repository at this point
Copy the full SHA 09b442dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d169bb1 - Browse repository at this point
Copy the full SHA d169bb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 211843e - Browse repository at this point
Copy the full SHA 211843eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4202c6 - Browse repository at this point
Copy the full SHA a4202c6View commit details
Commits on May 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a3f8f24 - Browse repository at this point
Copy the full SHA a3f8f24View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.