feat: ui for template registration in console wallet #5444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cifko
changed the title
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 12 suites +12 17m 53s ⏱️ + 17m 53s For more details on these failures, see this check. Results for commit 1ca7dfc. ± Comparison against base commit d492c30. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added code template registration tab to the console wallet.
The UI shows proper errors. It will not erase the fields when something is wrong.
Autofill everything that it can from the binary url (template name, version, type, repo link).
Computes the hash for the template.
Motivation and Context
The autofill works like this:
If the link is e.g.
https://github.com/tari-project/tari/blob/development/template.12.wasm.It will fill the repo as
https://github.com/tari-project/tariTemplate name
template, template version12, template typeWASM:1.The hash is always computed as of now, because there is no way for the user to generate it manually.
How Has This Been Tested?
Manually.
What process can a PR reviewer use to test or verify this change?
Register a code template, and look into the VN UI.
Breaking Changes