chore(ui): implement listening to outside app activity #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misieq01
force-pushed
the
feat/change-scope-of-user-activity-detection
branch
from
500f1ec
to
2fb1593
Compare
Misieq01
changed the title
Misieq01
changed the title
Misieq01
changed the title
kowalski
reviewed
Aug 7, 2024
kowalski
reviewed
Aug 7, 2024
There was a problem hiding this comment.
I'm not really a fan of doing this in javascript. How about rather having a task in rust check the mouse movement and then send an event to the javascript "User is idle". Then the autominer can carry on from there. You could probably actually just do the whole start/stop mining in rust as well
So you would like to leave only switching auto mining state in javascript and rest of the current logic move to rust ? |
stringhandler
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change autominer behavior so it would listen to user mouse movement outside app context
Motivation and Context
How Has This Been Tested?
Manually
What process can a PR reviewer use to test or verify this change?
Turn on autominer and position mouse outside app window then be idle for 30 seconds, minining should by then start and if you move mouse it should stop
Breaking Changes