Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup): critical errors when setup application #443

Merged

Conversation

mmrrnn
Copy link
Collaborator

@mmrrnn mmrrnn commented Sep 11, 2024

  • Added CriticalErrorDialog for critical errors that affect the app so we have to force the exit
  • Increased reliability of setup_application - filtered unimportant errors so they won't be treated as critical errors
  • Create common stop_all_miners method and use it for tauri::RunEvent::ExitRequested, tauri::RunEvent::Exit events and reset_settings , exit_application methods
  • Moved xmrig binaries to the binaries directory to unify with all rest
  • Small improvements: removed unused properties from appStateStore - setErrorOpen and errorOpen | implemented clone method for P2poolManager
    Screenshot from 2024-09-11 12-43-21

@mmrrnn mmrrnn force-pushed the critical_errors_when_setup_application branch from 161387e to 9f1ea43 Compare September 20, 2024 11:25
@stringhandler stringhandler merged commit fc1a437 into tari-project:main Sep 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants