fix: graceful exit #684
Open
fix: graceful exit #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
requested changes
Oct 2, 2024
Found and fixed and another commit issue with p2pool locking RWLock which caused dangling p2pool process. It was due p2pool trying to get status from status monitor which was already killed. |
src-tauri/src/process_watcher.rs
Outdated
| @@ -68,7 +68,9 @@ impl<TAdapter: ProcessAdapter> ProcessWatcher<TAdapter> { | |||
| loop { | |||
| select! { | |||
| _ = watch_timer.tick() => { | |||
| info!(target: LOG_TARGET, "Checking if {} is running", name); | |||
There was a problem hiding this comment.
Suggested change
| info!(target: LOG_TARGET, "Checking if {} is running", name); | |
| debug!(target: LOG_TARGET, "Checking if {} is running", name); |
src-tauri/src/process_watcher.rs
Outdated
| if child.ping() { | ||
| info!(target: LOG_TARGET, "{} is running", name); |
There was a problem hiding this comment.
Suggested change
| info!(target: LOG_TARGET, "{} is running", name); | |
| debug!(target: LOG_TARGET, "{} is running", name); |
src-tauri/src/p2pool_manager.rs
Outdated
| @@ -147,11 +147,12 @@ impl P2poolManager { | |||
| .await?; | |||
| process_watcher.wait_ready().await?; | |||
| if let Some(status_monitor) = &process_watcher.status_monitor { | |||
| loop { | |||
| for attempt in 1..=5 { | |||
| sleep(Duration::from_secs(5)).await; | |||
There was a problem hiding this comment.
5 seconds is very long here, rather make it 1 second but run more attempts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exiting app during initialization (especially during connecting to other peers) caused app to run some processes in the background.
Motivation and Context
Fix issue describe above.
How Has This Been Tested?
Run TU and exit during initialization while looking for other peers in the network.
What process can a PR reviewer use to test or verify this change?
Same as above
Breaking Changes