Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle missing microsoft visual c++ redistributable #725

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

Misieq01
Copy link
Collaborator

@Misieq01 Misieq01 commented Oct 4, 2024

[ Features WINDOWS ONLY ]

  • Implemented reading of installed applications on system
  • Added list of required external dependencies on system
  • Added detection if user have all required dependecies
  • Improved error handling to show what dependency is missing with link to download page

[ Notes ]

From what I've been testing gpu miner:

  • Will work fine with 2022 and 2019 packages
  • Throw non-zero exit code Some(-1073741515 for versions 2017 and 2015

Going with lower versions like 2012 will cause to app not starting at all and throwing error about missing msvcp140.dll which comes with versions 2015 and higher


[ Testing ]

  • Remove all Microsoft Visual C++ Redistributable packages from system
  • Install for example Microsoft Visual C++ Redistributable 2015 https://www.microsoft.com/pl-pl/download/details.aspx?id=48145
  • After opening application you should see information about missing packages
    image
  • After installing required versions application should continiue normally

[ Issues ]

  • On my machine I found that without any Microsoft Visual C++ Redistributable package I cannot even start application, getting error of missing msvcp140.dll

@Misieq01 Misieq01 marked this pull request as draft October 4, 2024 08:27
@Misieq01 Misieq01 changed the title fix: Handle missing Microsoft Visual C++ Redistributable fix: handle missing microsoft visual c++ redistributable Oct 4, 2024
@Misieq01 Misieq01 marked this pull request as ready for review October 4, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant