[Hub Generated] Review request for Microsoft.Attestation to add versi…

…on preview/2018-09-01-preview (Azure#8478)
tasharm-0412 · Mar 4, 2020 · dcfafba · dcfafba
1 parent e544dd0
commit dcfafba
Show file tree

Hide file tree

Showing 7 changed files with 181 additions and 22 deletions.
diff --git a/...tation/resource-manager/Microsoft.Attestation/preview/2018-09-01-preview/attestation.json b/...tation/resource-manager/Microsoft.Attestation/preview/2018-09-01-preview/attestation.json
@@ -63,7 +63,7 @@
     "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Attestation/attestationProviders/{providerName}": {
       "get": {
         "tags": [
-          "AttestationProvider"
+          "AttestationProviders"
         ],
         "operationId": "AttestationProviders_Get",
         "description": "Get the status of Attestation Provider.",
@@ -107,7 +107,7 @@
       },
       "put": {
         "tags": [
-          "AttestationProvider"
+          "AttestationProviders"
         ],
         "operationId": "AttestationProviders_Create",
         "description": "Creates or updates the Attestation Provider.",
@@ -136,6 +136,7 @@
           {
             "name": "creationParams",
             "in": "body",
+            "required": true,
             "description": "Client supplied parameters.",
             "schema": {
               "$ref": "#/definitions/AttestationServiceCreationParams"
@@ -164,9 +165,63 @@
           }
         }
       },
+      "patch": {
+        "tags": [
+          "AttestationProviders"
+        ],
+        "operationId": "AttestationProviders_Update",
+        "description": "Updates the Attestation Provider.",
+        "x-ms-examples": {
+          "AttestationProviders_Update": {
+            "$ref": "./examples/Update_AttestationProvider.json"
+          }
+        },
+        "parameters": [
+          {
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/SubscriptionIdParameter"
+          },
+          {
+            "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
+          },
+          {
+            "name": "providerName",
+            "in": "path",
+            "required": true,
+            "type": "string",
+            "description": "Name of the attestation service"
+          },
+          {
+            "$ref": "#/parameters/ApiVersionParameter"
+          },
+          {
+            "name": "updateParams",
+            "in": "body",
+            "required": true,
+            "description": "Client supplied parameters.",
+            "schema": {
+              "$ref": "#/definitions/AttestationServicePatchParams"
+            },
+            "x-ms-parameter-location": "method"
+          }
+        ],
+        "responses": {
+          "200": {
+            "description": "Updated attestation service",
+            "schema": {
+              "$ref": "#/definitions/AttestationProvider"
+            }
+          },
+          "default": {
+            "description": "Error result from Attestation service",
+            "schema": {
+              "$ref": "#/definitions/CloudError"
+            }
+          }
+        }
+      },
       "delete": {
         "tags": [
-          "AttestationProvider"
+          "AttestationProviders"
         ],
         "operationId": "AttestationProviders_Delete",
         "description": "Delete Attestation Service.",
@@ -344,7 +399,7 @@
       ],
       "allOf": [
         {
-          "$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/Resource"
+          "$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/TrackedResource"
         }
       ],
       "properties": {
@@ -363,6 +418,10 @@
         "status"
       ],
       "properties": {
+        "trustModel": {
+          "type": "string",
+          "description": "Trust model for the attestation service instance."
+        },
         "status": {
           "type": "string",
           "description": "Status of attestation service.",
@@ -417,8 +476,46 @@
         }
       }
     },
+    "AttestationServicePatchParams": {
+      "description": "Parameters for patching an attestation service instance",
+      "x-ms-azure-resource": true,
+      "properties": {
+        "tags": {
+          "type": "object",
+          "additionalProperties": {
+            "type": "string"
+          },
+          "description": "The tags that will be assigned to the attestation service instance."
+        }
+      }
+    },
     "AttestationServiceCreationParams": {
-      "description": "Client supplied parameters passed to attestation service.",
+      "description": "Parameters for creating an attestation service instance",
+      "required": [
+        "location",
+        "properties"
+      ],
+      "x-ms-azure-resource": true,
+      "properties": {
+        "location": {
+          "type": "string",
+          "description": "The supported Azure location where the attestation service instance should be created."
+        },
+        "tags": {
+          "type": "object",
+          "additionalProperties": {
+            "type": "string"
+          },
+          "description": "The tags that will be assigned to the attestation service instance."
+        },
+        "properties": {
+          "$ref": "#/definitions/AttestationServiceCreationSpecificParams",
+          "description": "Properties of the attestation service instance"
+        }
+      }
+    },
+    "AttestationServiceCreationSpecificParams": {
+      "description": "Client supplied parameters used to create a new attestation service instance.",
       "properties": {
         "attestationPolicy": {
           "type": "string",

diff --git a/...Microsoft.Attestation/preview/2018-09-01-preview/examples/Create_AttestationProvider.json b/...Microsoft.Attestation/preview/2018-09-01-preview/examples/Create_AttestationProvider.json
@@ -3,29 +3,43 @@
     "resourceGroupName": "MyResourceGroup",
     "subscriptionId": "00000000-0000-0000-0000-000000000000",
     "api-version": "2018-09-01-preview",
-    "providerName": "MyAttestationProvider",
+    "providerName": "myattestationprovider",
     "creationParams": "test"
   },
   "responses": {
     "200": {
       "body": {
-        "id": "subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/MyResourceGroup/providers/Microsoft.Attestation/attestationProviders/MyAttestationProvider",
-        "name": "MyAttestationProvider",
+        "id": "subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/MyResourceGroup/providers/Microsoft.Attestation/attestationProviders/myattestationprovider",
+        "name": "myattestationprovider",
         "type": "Microsoft.Attestation/attestationProviders",
+        "location": "East US",
+        "tags": {
+          "Property1": "Value1",
+          "Property2": "Value2",
+          "Property3": "Value3"
+        },
         "properties": {
+          "trustModel": "Isolated",
           "status": "Ready",
-          "attestUri": "https://sample-attestation.attestation.azure.net"
+          "attestUri": "https://superservice.attestation.azure.net"
         }
       }
     },
     "201": {
       "body": {
-        "id": "subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/MyResourceGroup/providers/Microsoft.Attestation/attestationProviders/MyAttestationProvider",
-        "name": "MyAttestationProvider",
+        "id": "subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/MyResourceGroup/providers/Microsoft.Attestation/attestationProviders/myattestationprovider",
+        "name": "myattestationprovider",
         "type": "Microsoft.Attestation/attestationProviders",
+        "location": "East US",
+        "tags": {
+          "Property1": "Value1",
+          "Property2": "Value2",
+          "Property3": "Value3"
+        },
         "properties": {
+          "trustModel": "Isolated",
           "status": "Ready",
-          "attestUri": "https://sample-attestation.attestation.azure.net"
+          "attestUri": "https://superservice.attestation.azure.net"
         }
       }
     }

diff --git a/...Microsoft.Attestation/preview/2018-09-01-preview/examples/Delete_AttestationProvider.json b/...Microsoft.Attestation/preview/2018-09-01-preview/examples/Delete_AttestationProvider.json
@@ -1,9 +1,10 @@
 {
   "parameters": {
-    "resourceGroupName": "MyResourceGroup",
+    "resourceGroupName": "sample-resource-group",
+    "serviceName": "sampleservicename",
     "subscriptionId": "00000000-0000-0000-0000-000000000000",
     "api-version": "2018-09-01-preview",
-    "providerName": "MyAttestationProvider"
+    "providerName": "myattestationprovider"
   },
   "responses": {
     "202": {

diff --git a/...er/Microsoft.Attestation/preview/2018-09-01-preview/examples/Get_AttestationProvider.json b/...er/Microsoft.Attestation/preview/2018-09-01-preview/examples/Get_AttestationProvider.json
@@ -3,16 +3,24 @@
     "resourceGroupName": "MyResourceGroup",
     "subscriptionId": "00000000-0000-0000-0000-000000000000",
     "api-version": "2018-09-01-preview",
-    "providerName": "MyAttestationProvider"
+    "providerName": "myattestationprovider"
   },
   "responses": {
     "200": {
       "body": {
-        "id": "subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/MyResourceGroup/providers/Microsoft.Attestation/attestationProviders/MyAttestationProvider",
-        "name": "MyAttestationProvider",
+        "id": "subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/MyResourceGroup/providers/Microsoft.Attestation/attestationProviders/myattestationprovider",
+        "name": "myattestationprovider",
         "type": "Microsoft.Attestation/attestationProviders",
+        "location": "East US",
+        "tags": {
+          "Property1": "Value1",
+          "Property2": "Value2",
+          "Property3": "Value3"
+        },
         "properties": {
-          "status": "Ready"
+          "trustModel": "Isolated",
+          "status": "Ready",
+          "attestUri": "https://superservice.attestation.azure.net"
         }
       }
     }

diff --git a/...crosoft.Attestation/preview/2018-09-01-preview/examples/Get_AttestationProvidersList.json b/...crosoft.Attestation/preview/2018-09-01-preview/examples/Get_AttestationProvidersList.json
@@ -8,9 +8,10 @@
       "body": {
         "value": [
           {
-            "id": "subscriptions/6c96b33e-f5b8-40a6-9011-5cb1c58b0915/resourceGroups/testrg1/providers/Microsoft.Attestation/attestationProviders/MyAttestationProvider",
-            "name": "MyAttestationProvider",
+            "id": "subscriptions/6c96b33e-f5b8-40a6-9011-5cb1c58b0915/resourceGroups/testrg1/providers/Microsoft.Attestation/attestationProviders/myattestationprovider",
+            "name": "myattestationprovider",
             "type": "Microsoft.Attestation/attestationProviders",
+            "location": "East US",
             "properties": {
               "status": "Ready"
             }
@@ -19,6 +20,7 @@
             "id": "subscriptions/6c96b33e-f5b8-40a6-9011-5cb1c58b0915/resourceGroups/testrg2/providers/Microsoft.Attestation/attestationProviders/codes2",
             "name": "codes2",
             "type": "Microsoft.Attestation/attestationProviders",
+            "location": "East US",
             "properties": {
               "status": "Ready"
             }

diff --git a/...tion/preview/2018-09-01-preview/examples/Get_AttestationProvidersListByResourceGroup.json b/...tion/preview/2018-09-01-preview/examples/Get_AttestationProvidersListByResourceGroup.json
@@ -9,9 +9,10 @@
       "body": {
         "value": [
           {
-            "id": "subscriptions/6c96b33e-f5b8-40a6-9011-5cb1c58b0915/resourceGroups/testrg1/providers/Microsoft.Attestation/attestationProviders/MyAttestationProvider",
-            "name": "MyAttestationProvider",
+            "id": "subscriptions/6c96b33e-f5b8-40a6-9011-5cb1c58b0915/resourceGroups/testrg1/providers/Microsoft.Attestation/attestationProviders/myattestationprovider",
+            "name": "myattestationprovider",
             "type": "Microsoft.Attestation/attestationProviders",
+            "location": "East US",
             "properties": {
               "status": "Ready"
             }
@@ -20,6 +21,7 @@
             "id": "subscriptions/6c96b33e-f5b8-40a6-9011-5cb1c58b0915/resourceGroups/testrg1/providers/Microsoft.Attestation/attestationProviders/codes2",
             "name": "codes2",
             "type": "Microsoft.Attestation/attestationProviders",
+            "location": "East US",
             "properties": {
               "status": "Ready"
             }

diff --git a/...Microsoft.Attestation/preview/2018-09-01-preview/examples/Update_AttestationProvider.json b/...Microsoft.Attestation/preview/2018-09-01-preview/examples/Update_AttestationProvider.json
@@ -0,0 +1,35 @@
+{
+  "parameters": {
+    "resourceGroupName": "MyResourceGroup",
+    "subscriptionId": "00000000-0000-0000-0000-000000000000",
+    "api-version": "2018-09-01-preview",
+    "providerName": "myattestationprovider",
+    "updateParams": {
+      "tags": {
+        "Property1": "Value1",
+        "Property2": "Value2",
+        "Property3": "Value3"
+      }
+    }
+  },
+  "responses": {
+    "200": {
+      "body": {
+        "id": "subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/MyResourceGroup/providers/Microsoft.Attestation/attestationProviders/myattestationprovider",
+        "name": "myattestationprovider",
+        "type": "Microsoft.Attestation/attestationProviders",
+        "location": "East US",
+        "tags": {
+          "Property1": "Value1",
+          "Property2": "Value2",
+          "Property3": "Value3"
+        },
+        "properties": {
+          "trustModel": "Isolated",
+          "status": "Ready",
+          "attestUri": "https://superservice.attestation.azure.net"
+        }
+      }
+    }
+  }
+}