Copy of C++ spline lead to 2 splines sharing core

This is more readable and avoids copy bugs. Transformation operations should always end in copies of the original,
regardless of wheteher type was changed or not

splinepy/bezier.py

@@ -342,12 +342,12 @@ def __init__(self, degrees=None, control_points=None, spline=None):
 
     @property
     def bezier(self):
-        return settings.NAME_TO_TYPE["Bezier"](spline=self)
+        return settings.NAME_TO_TYPE["Bezier"](**self.todict())
 
     @property
     def rationalbezier(self):
         return settings.NAME_TO_TYPE["RationalBezier"](
-            **self.todict(), weights=np.ones((len(self.cps), 1))
+            **self.todict(), weights=np.ones((self.cps.shape[0], 1))
         )
 
     @property

splinepy/bspline.py

@@ -677,7 +677,7 @@ def approximate_surface(
 
     @property
     def bspline(self):
-        return settings.NAME_TO_TYPE["BSpline"](spline=self)
+        return settings.NAME_TO_TYPE["BSpline"](**self.todict())
 
     @property
     def nurbs(self):

splinepy/microstructure/microstructure.py

@@ -289,7 +289,9 @@ def create(self, closing_face=None, knot_span_wise=None, **kwargs):
 
         # Prepare the deformation function
         # Transform into a non-uniform splinetype and make sure to work on copy
-        if hasattr(self._deformation_function, "bspline"):
+        if "BSpline" in self._deformation_function.whatami:
+            deformation_function_copy = self._deformation_function.copy()
+        elif hasattr(self._deformation_function, "bspline"):
             deformation_function_copy = self._deformation_function.bspline
         else:
             deformation_function_copy = self._deformation_function.nurbs

splinepy/nurbs.py

@@ -148,4 +148,4 @@ def __init__(
 
     @property
     def nurbs(self):
-        return settings.NAME_TO_TYPE["NURBS"](spline=self)
+        return settings.NAME_TO_TYPE["NURBS"](**self.todict())