Updated Tests and rebased

tataratat · Jun 26, 2023 · b6099f4 · b6099f4
1 parent a7aa1d4
commit b6099f4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/splinepy/bspline.py b/splinepy/bspline.py
@@ -70,7 +70,7 @@ def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
 
     @spline._new_core_if_modified
-    def insert_knots(self, parametric_dimension, knots, return_matrix=False):
+    def insert_knots(self, parametric_dimension, knots):
         """
         Inserts knots.
 
@@ -169,6 +169,7 @@ def knot_insertion_matrix(
             else:
                 matrix = np.zeros(data[1])
                 matrix[data[0][1][0], data[0][1][1]] = data[0][0]
+
 
 
         data = splinepy_core.global_knot_insertion_matrix(

diff --git a/tests/test_kv_manipulation.py b/tests/test_kv_manipulation.py
@@ -104,15 +104,15 @@ def test_insert_knot_with_matrix(self):
         matrix_nurbs = self.nurbs.knot_insertion_matrix(
             0, nurbs_knots_0
         )
+        self.nurbs.insert_knots(
+            0, nurbs_knots_0
+        )
         matrix_nurbs = (
             self.nurbs.knot_insertion_matrix(
                 1, nurbs_knots_1
             )
             @ matrix_nurbs
         )
-        self.nurbs.insert_knots(
-            0, nurbs_knots_0
-        )
         self.nurbs.insert_knots(
             1, nurbs_knots_1
         )