Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented reading of irit files #181

Merged
merged 5 commits into from
Jul 13, 2023
Merged

Implemented reading of irit files #181

merged 5 commits into from
Jul 13, 2023

Conversation

markriegler
Copy link
Collaborator

Overview

Loading irit files is now supported.

Comment

Nltk is used to extract the control point and knot vector entries.

@clemens-fricke
Copy link
Member

Please add the nltk package to the dependencies. This needs to be done in the README.md and setup.py files. I am not sure if this will fix all the errors, but it should fix a few.

@jzwar
Copy link
Collaborator

jzwar commented Jul 10, 2023

Please add the nltk package to the dependencies. This needs to be done in the README.md and setup.py files. I am not sure if this will fix all the errors, but it should fix a few.

As I said during your implementation, I am not a huge fan of adding nltk as a dependency. It is a very powerful tool, but we only use a tiny part of it.

I am not sure if you are still available for future changes, so I will take the liberty to merge your implementation into a separate branch and continue with a keyword-based approach.

Copy link
Member

@j042 j042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! now, only xml and iges left ;)

@jzwar jzwar merged commit 1ee8ba5 into main Jul 13, 2023
23 checks passed
@jzwar jzwar deleted the ft-read-irit branch July 13, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants