Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): pin winnow dependency to 0.4.1 to keep 1.60 MSRV #6845

Merged
merged 1 commit into from
May 3, 2023

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner May 3, 2023 12:14
@lucasfernog lucasfernog merged commit 0dfd5f8 into dev May 3, 2023
@lucasfernog lucasfernog deleted the fix/winnow-msrv branch May 3, 2023 12:32
@epage
Copy link

epage commented May 11, 2023

FYI for lib crates using = can break people if they are also using the crate.

Examples:

Generally, unless a crate is a [[bin]] or will only be used by a [[bin]], you should rely on Cargo.lock for resolving MSRV problems.

Of course rust-lang/cargo#9930 makes this problem go away and we are working towards it.

epage referenced this pull request in dbus2/zbus May 18, 2023
winnow 0.4.2 bumped MSRV to 1.64. We want to bump our MSRV only after
Tauri does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

4 participants