When calling the Taxjar client DeleteOrder or DeleteRefund API routin… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es, the JsonConvert.DeserializeObject routine was throwing an exception for decimal fields since the Taxjar service is not returning these fields in the response. The changes to the Taxjar.Order and Taxjar.Refund classes fixes this issue. The changes made to the csproj files were needed to get the solution to compile. All tests were ran and passed. I also have tests in my client's code which test that these changes work from an integration test prospective.
|
@MartinMcCaulley I'll check this out shortly, thank you for the PR! |
|
Welcome.
The changes to the csproj files could be dropped if needed and it appears
our Visual Studio settings are different for indentation (sorry about
that).
The real change here is simply adding the "NullValueHandling =
NullValueHandling.Ignore" attribute to the decimal properties in the
Taxjar.Order and Taxjar.Refund classes.
Regards,
Martin
…On Fri, Feb 17, 2017 at 3:26 PM, Jake Johnson ***@***.***> wrote:
@MartinMcCaulley <https://github.com/MartinMcCaulley> I'll check this out
shortly, thank you for the PR!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AYqAgVqkbztdgmLBgJVNYam1WUxw6K6hks5rdiySgaJpZM4ME3mg>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es, the JsonConvert.DeserializeObject routine was throwing an exception for decimal fields since the Taxjar service is not returning these fields in the response. The changes to the Taxjar.Order and Taxjar.Refund classes fixes this issue. The changes made to the csproj files were needed to get the solution to compile. All tests were ran and passed. I also have tests in my client's code which test that these changes work from an integration test prospective.