Fix tax breakdown attribute deserialization #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default RestSharp uses SimpleJson for deserializing responses. `DeserializeAs` has a variety of issues with nested JSON and underscores. Until RestSharp brings it back, we should always use Newtonsoft.Json for deserializing objects in the API client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special district attributes in the order-level and shipping breakdowns for /v2/taxes were returning zero. Our specs didn't catch this because the fixture contained zero values for special district. RestSharp's default JSON serializer via SimpleJson wasn't picking up the mapped JSON properties, so we need to make sure that responses are always deserialized using Newtonsoft.Json. RestSharp plans to use Newtonsoft.Json in an upcoming version.