Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pool run health check #86

Merged
merged 1 commit into from
May 12, 2023
Merged

Remove pool run health check #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...center/azext_devcenter/aaz/latest/devcenter/admin/network_connection/_run_health_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

from azure.cli.core.aaz import *


@register_command(
"devcenter admin network-connection run-health-check",
)
Expand Down
2 changes: 1 addition & 1 deletion src/devcenter/azext_devcenter/aaz/latest/devcenter/admin/pool/_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
help="Name of a network connection in parent project of this pool.",
)

#TODO: re-add once idle is ready, uncomment other blocks of code below
#TODO: Uncomment once idle is ready, uncomment other blocks of code below
# _args_schema.stop_on_disconnect = AAZObjectArg(
# options=["--stop-on-disconnect"],
# arg_group="Properties",
Expand Down
8 changes: 4 additions & 4 deletions src/devcenter/azext_devcenter/aaz/latest/devcenter/admin/pool/_run_health_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@

from azure.cli.core.aaz import *


@register_command(
"devcenter admin pool run-health-check",
)
#TODO: Uncomment once feature is complete
# @register_command(
# "devcenter admin pool run-health-check",
# )
class RunHealthCheck(AAZCommand):
"""Triggers a refresh of the pool status.

Expand Down
2 changes: 1 addition & 1 deletion src/devcenter/azext_devcenter/aaz/latest/devcenter/admin/pool/_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
help="Name of a network connection in parent project of this pool.",
)

#TODO: re-add once idle is ready, uncomment out other blocks of code in this file
#TODO: Uncomment once idle is ready, uncomment out other blocks of code in this file
# _args_schema.stop_on_disconnect = AAZObjectArg(
# options=["--stop-on-disconnect"],
# arg_group="Properties",
Expand Down
8 changes: 4 additions & 4 deletions src/devcenter/azext_devcenter/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
PoolCreate,
PoolDelete,
PoolList,
PoolRunHealthCheck,
PoolShow,
PoolUpdate,
PoolWait,
Expand Down Expand Up @@ -163,9 +162,10 @@ def load_command_table(self, _):
self.command_table["devcenter admin pool create"] = PoolCreate(loader=self)
self.command_table["devcenter admin pool delete"] = PoolDelete(loader=self)
self.command_table["devcenter admin pool list"] = PoolList(loader=self)
self.command_table["devcenter admin pool run-health-check"] = PoolRunHealthCheck(
loader=self
)
# TODO: Uncomment once feature is complete
# self.command_table["devcenter admin pool run-health-check"] = PoolRunHealthCheck(
# loader=self
# )
self.command_table["devcenter admin pool show"] = PoolShow(loader=self)
self.command_table["devcenter admin pool update"] = PoolUpdate(loader=self)
self.command_table["devcenter admin pool wait"] = PoolWait(loader=self)
Expand Down
12 changes: 6 additions & 6 deletions src/devcenter/azext_devcenter/tests/latest/test_devcenter_scenario.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,8 +903,8 @@ def test_pool_scenario(self):
],
)

# TODO: add health check and health check details in return type when API available
# TODO: add stopOnDisconnect idle back when available
# TODO: Add health check and health check details in return type when API available
# TODO: Add stopOnDisconnect idle back when available
self.cmd(
"az devcenter admin pool create "
'-d "{devBoxDefinitionName}" '
Expand Down Expand Up @@ -963,7 +963,7 @@ def test_pool_scenario(self):
],
)

# TODO: Not available yet, add test when it is
# TODO: Uncomment once feature is complete
# self.cmd(
# "az devcenter admin pool run-health-check "
# '--name "{poolName}" '
Expand Down Expand Up @@ -1516,7 +1516,7 @@ def test_pool_dataplane_scenario(self):
],
)

# TODO add back idle checks once feature is available
# TODO Add back idle parameters and checks once feature is complete

self.cmd(
"az devcenter dev pool show "
Expand Down Expand Up @@ -1924,7 +1924,7 @@ def test_dev_box_dataplane_scenario(self):
'--dev-center "{devcenterName}" '
)

# TODO: restart not working
# TODO: Restart not working, re-run test once fixed
# self.cmd(
# "az devcenter dev dev-box restart "
# '--name "{devBoxName}" '
Expand Down Expand Up @@ -1966,7 +1966,7 @@ def test_dev_box_dataplane_scenario(self):
'--dev-center "{devcenterName}" '
).get_output_in_json()

# TODO: recheck for idle once available
# TODO: Recheck for idle once feature is complete
self.kwargs.update(
{
"actionName": stopAction[0]["name"],
Expand Down