Editorial: Fixup grammatical parameters #1929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR tc39#1869 removed/changed the [U] parameter in certain defining productions, but missed some collateral changes in referring productions.
|
Actually I there may have been other issues, which I'm working on a PR to fix. That PR would supersede this, so let's hold off for now. |
|
See #1932. |
|
Well, this PR may not be needed, but it looks like #1932 has problems of its own. (So that'll probably be another PR.) |
|
In that case, can we update this PR in place? |
|
We could, but that doesn't make sense to me. |
|
(new PR is #1935) |
|
The reason I ask is that every new PR adds noise to both the repo, and the git log (if fetching PR refs), forever. Please reuse related PRs in the future :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1869 removed/changed the [U] parameter in certain defining productions, but missed some collateral changes in referring productions.