Add a test verifying that duplicate variants in the tlang component of a language tag make it structurally invalid #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswalden
force-pushed
the
test-duplicate-variants-in-tlang-rejected
branch
from
f9ff3d7
to
cdd06ae
Compare
|
could we separate the dup variant and dup tl into two different test files? |
|
Just split them into two files like |
… component of a tag, make it structurally invalid.
jswalden
force-pushed
the
test-duplicate-variants-in-tlang-rejected
branch
from
cdd06ae
to
d603eec
Compare
|
I would be surprised if we don't have tests for rejecting duplicate variants already -- I included them mostly for reader understandability -- but sure, split into separate tests, with corresponding wording changes and so on. |
rwaldron
approved these changes
Oct 9, 2020
|
@syg heads up for failures in V8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is currently un-exercised so may contain tpyos or similar -- posting so I can test that it works correctly against SM by importing it.)