Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DecoratedRoomAvatar displays wrong when not inline #890

Closed
estellecomment opened this issue Feb 8, 2024 · 1 comment
Closed

DecoratedRoomAvatar displays wrong when not inline #890

estellecomment opened this issue Feb 8, 2024 · 1 comment
Labels
bug Something isn't working proposal to element regression - caused by update

Comments

@estellecomment
Copy link
Contributor

Should look like :
image

Instead the decoration (green lock) is badly aligned, when used in the RoomSummaryCard :
image

Issue should be opened in element-web.
@estellecomment
Copy link
Contributor Author

Because the width of the parent el stretches to the whole width of the sidebar, instead of being contained to just the pink circle. So the positioning for "right:0%" is at the edge of the sidebar, not the edge of the pink circle.

Temp fix in a patch : add an empty parent div with the right width (position: relative, display: inline-block)
Fixed in _TchapDecoratedRoomAvatar.pcss and DecoratedRoomAvatar.tsx

@estellecomment estellecomment mentioned this issue Feb 8, 2024
Merged
15 tasks
estellecomment added a commit that referenced this issue Feb 8, 2024
@estellecomment
Fix DecoratedRoomAvatar display bug #890
bcea8b7
odelcroi added a commit that referenced this issue Feb 14, 2024
@estellecomment @renovate
@t3chguy @dhenneke @richvdh @germain-gg @Subash-Lamichhane @Johennes @RiotRobot @dependabot @uhoreg @toger5 @aceArt-GmbH @langleyd @florianduros @odelcroi
Upgrade/element web v1.11.53 (#887)
263c934 
* Update all non-major dependencies (#26201)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>

* Update build.yml

* Lock file maintenance (#26205)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency typescript to v5.2.2 (#26390)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>

* Correctly fill window.matrixChat even when a Wrapper module is active (#26395)

Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>

* Update react-types (#26124)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add automation to move Element-R issues to crypto board (#26398)

* triage-labelled: Fix workflow

* Adds labs label to Element R issues (#26324)

* triage-labelled: Fix step input names

* triage-labelled: also set "Status" on ER issues

* Revert "triage-labelled: also set "Status" on ER issues"

This reverts commit e4d365a.

This is better done through the project board automation, otherwise we risk
moving items out of "In Progress" back to "Qualification".

* docs: fixed multiple typos (#26403)

* OIDC: document config (#26400)

* document OIDC config

* tidy

* Delete .github/workflows/upgrade_dependencies.yml

* Update triage-assigned.yml

Update user name

* Enable rust cryptography on develop.element.io (#26291)

Once this lands, *existing* sessions will continue to use legacy crypto, but
*new* logins will use rust crypto.

* Upgrade matrix-react-sdk to 3.83.0

* Upgrade matrix-js-sdk to 29.1.0

* Prepare changelog for v1.11.47

* v1.11.47

* Reset matrix-react-sdk back to develop branch

* Reset matrix-js-sdk back to develop branch

* Document `feedback.new_issue_url` & `feedback.existing_issues_url` (#26446)

* Update update-topics.yaml

* Update update-topics.yaml

* Iterate build_debian.yaml workflow (#26434)

* Update config.md

* Appease the linter

* Add mdbook-mermaid (#26426)

* Update docs.yml

* Remove mermaid config section

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Add script to generate mermaid graph of automations (#26432)

* Update docs.yml

* Bump browserify-sign from 4.2.1 to 4.2.2 (#26459)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update docs.yml

* Update docs.yml

* Vendor in Mermaid v10 for frontmatter title support

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Fix path issues

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* prettierignore

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Fix docs workflow

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Use olm from default npm registry, since it's there now (#26461)

* Release prep script for cutting branches (#26392)

* Update release_prepare.yml

* Upgrade matrix-react-sdk to 3.84.0-rc.1

* Upgrade matrix-js-sdk to 30.0.0-rc.1

* Prepare changelog for v1.11.48-rc.1

* v1.11.48-rc.1

* Update titoportas/update-project-fields digest to 421a544 (#26478)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update definitelyTyped (#26479)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency @types/jest to v29.5.7 (#26480)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update actions/setup-node action to v4 (#26484)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency eslint-plugin-unicorn to v49 (#26485)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update all non-major dependencies (#26482)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update build_debian.yaml

* Ship OpenCoDE variant to Dockerhub (#26399)

* Make triage-labelled workflow reusable

* Add input parameter for ELEMENT_BOT_TOKEN

* Upgrade matrix-react-sdk to 3.84.0

* Upgrade matrix-js-sdk to 30.0.0

* Prepare changelog for v1.11.48

* v1.11.48

* Reset matrix-react-sdk back to develop branch

* Reset matrix-js-sdk back to develop branch

* Upgrade webpack to 5.89.0

* Remove unused extract-text-webpack-plugin

* Replace optimize-css-assets-webpack-plugin with css-minimizer-webpack-plugin

* Eliminate use of loader-utils

* Appease the linter

* Ship element-web as a debian package (#26533)

* Update @matrix-org/react-sdk-module-api

* Remove obsolete comment

* Only show overlay on build errors

* Eliminate worklet-loader

* Appease the linter

* Only update repo description once (#26517)

* Update translating-dev.md

* Run Localazy Download on a schedule 3 times a week instead of during release process (#26550)

* Add defaults and fix comment

* Disable automatic publicPath to unbreak worklets

* Update CODEOWNERS

* [create-pull-request] automated change

* [Backport staging] Ship element-web as a debian package (#26563)

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>

* Upgrade matrix-react-sdk to 3.84.1

* Upgrade matrix-js-sdk to 30.0.1

* Prepare changelog for v1.11.49

* v1.11.49

* Update build_debian.yaml

* New release automations (#26495)

* Squashed commit of the following:

commit 069c1bc8331b460275caf492450436f5e127f767
Author: Johannes Marbach <johannesm@element.io>
Date:   Sat Nov 11 16:08:30 2023 +0100

    Replace worker-loader with built-in Webpack 5 support for web workers

* Update mocks for workers / worklets

* Update release-drafter.yml

* Update build_develop.yml

* Explicitly specify secrets

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Upgrade matrix-react-sdk to 3.85.0-rc.1

* Upgrade matrix-js-sdk to 30.1.0-rc.1

* v1.11.50-rc.0

* Use only chokidar for watching and add more logging

* Appease the linter

* Prevent copy-res -w from triggering unnecessary changes while webpack is already building

* Remove unused dependencies and add transitive deps (#26543)

* Update actions/github-script action to v7 (#26583)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update all non-major dependencies (#26581)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Bump crypto-js from 4.1.1 to 4.2.0 (#26460)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update definitelyTyped (#26579)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update babel monorepo to v7.23.3 (#26578)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>

* Update dependency @types/jest to v29.5.8 (#26580)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>

* Update build_debian.yaml

* v1.11.50-rc.1

* Replace copy/watching of non-language assets with copy-webpack-plugin

* Try explicitly relative path for config.json

* Revert "Try explicitly relative path for config.json"

This reverts commit 46ecafa.

* Allow config.json to be missing

* Update copy-webpack-plugin to latest

* Undo auto public path disablement as it doesn't work with workers

* Add feature_disable_call_per_sender_encryption documentation (in labs.md) (#26548)

* add feature_disable_call_per_sender_encryption doc

Co-authored-by: aceArt-GmbH <33117017+aceArt-GmbH@users.noreply.github.com>

---------

Signed-off-by: Timo K <toger5@hotmail.de>
Co-authored-by: aceArt-GmbH <33117017+aceArt-GmbH@users.noreply.github.com>

* Add custom loader for recorder worklet

* Move worklet rule up to where it used to be

* Set es2022 globally but force CommonJS when using ts-node for scripts

* Add documentation around releases (#26602)

* Upgrade matrix-react-sdk to 3.85.0

* Upgrade matrix-js-sdk to 30.1.0

* v1.11.50

* Update release-gitflow.yml

* Reset matrix-react-sdk back to develop branch

* Reset matrix-js-sdk back to develop branch

* Update CHANGELOG.md

* Set up rudimentary workflow for manually triggering label sync

* Make it preeeeeetty

* Use correct key

* Rename action to not tap outside exclusion list

* Add labels currently added with respect to element-meta

* Fix quotes

* Quote names

* Prettier

* Improve debian package and docs (#26618)

* Setup CI to lint workflows with action-validator

* Add Jitsi SDK as a static resource and set up CI to update it on change

* Make prettier ignore jitsi_external_api.min.js

* Improve rendering style of markdown in the mdbook (#26616)

* Update path

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Add license and copy it into bundle while making terser ignore the SDK

* Enable new room header by default on develop

Relates to: element-hq/element-web#25883

* Adapt to renaming of release-action workflow

* Improve Module API docs & example (#26637)

* Fix types

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Upgrade matrix-react-sdk to 3.86.0-rc.2

* Upgrade matrix-js-sdk to 30.2.0-rc.0

* v1.11.51-rc.0

* Update definitelyTyped (#26666)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update docker/build-push-action digest to 4a13e50 (#26663)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update babel monorepo to v7.23.4 (#26665)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update all non-major dependencies (#26664)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency @types/jest to v29.5.10 (#26667)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency typescript to v5.3.2 (#26668)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [create-pull-request] automated change

* Adapt label-sync workflow to new version of upstream workflow

* Add missing labels for label sync

This adds all the labels that element-web has over element-meta to labels.yml. There is some deduplication to do that we can take care of over time. This at least should ensure that we don't lose anything we have to day while still benefiting from label sync.

* Replace quotes

* Pretty it up

* Enable label sync workflow

* Undry the workflow

* Upgrade matrix-react-sdk to 3.86.0

* Upgrade matrix-js-sdk to 30.2.0

* v1.11.51

* Reset matrix-react-sdk back to develop branch

* Reset matrix-js-sdk back to develop branch

* Add @nordeck/element-web-opendesk-module@0.3.0 to variants/openDesk/build_config.yaml

Signed-off-by: Charly Nguyen <charly.nguyen@nordeck.net>

* [create-pull-request] automated change

* update to org to element-hq

* Update org in scripts and workflows

* Upgrade matrix-react-sdk to 3.87.0-rc.0

* Upgrade matrix-js-sdk to 30.3.0-rc.0

* v1.11.52-rc.0

* Upgrade matrix-react-sdk to 3.87.0

* Upgrade matrix-js-sdk to 30.3.0

* v1.11.52

* Upgrade matrix-react-sdk to 3.88.0

* v1.11.53

* Remove useless patch better-text-for-tab-switch

* Upgrade patches

* Upgrade conflicting patches

* Upgrade conflict patch bug-reporting. Remove two files from the patch, not needed any more.

* Upgrade conflicted patch customize-room-header-bar

* Upgrade conflicted patch export-room-members

* Upgrade more conflicting patches

* Remove patch remove-fdroid (bug is fixed)

* Remove better-text-for-tab-switch from patches.json

* Fix conflicted patch show-icon-on-public-room

* Last patch fix

* Translation fixes + an updated getVersionInfo for the rust crypto version.

* Fix customize-room-header-bar : messed up brackets

* New style for Export room members button

* Remove no-voip-mentions-in-onboarding patch. Replace with custom translation and customisations-replaced image.

* Fix DecoratedRoomAvatar display bug #890

* Fix one last translation

* Update cypress tests

* Delete .github/labels.yml

we don't neeed extra labels

* fix use of MatrixClientContext

---------

Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Timo K <toger5@hotmail.de>
Signed-off-by: Charly Nguyen <charly.nguyen@nordeck.net>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Co-authored-by: Dominik Henneke <dominik.henneke@nordeck.net>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <richard@matrix.org>
Co-authored-by: Germain <germain@souquet.com>
Co-authored-by: Subash-Lamichhane <109226874+Subash-Lamichhane@users.noreply.github.com>
Co-authored-by: Kerry <kerrya@element.io>
Co-authored-by: Johannes Marbach <johannesm@element.io>
Co-authored-by: ElementRobot <releases@riot.im>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
Co-authored-by: Charly Nguyen <charly.nguyen@nordeck.net>
Co-authored-by: t3chguy <t3chguy@users.noreply.github.com>
Co-authored-by: Timo <16718859+toger5@users.noreply.github.com>
Co-authored-by: aceArt-GmbH <33117017+aceArt-GmbH@users.noreply.github.com>
Co-authored-by: David Langley <langley.dave@gmail.com>
Co-authored-by: Florian Duros <florianduros@element.io>
Co-authored-by: Olivier D <odelcroi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working proposal to element regression - caused by update
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@estellecomment