-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sso): add email domain precheck sso flow #1111
base: develop_tchap
Are you sure you want to change the base?
Conversation
c89dc2c
to
867d274
Compare
867d274
to
8e9bc0f
Compare
557b499
to
390d1a6
Compare
390d1a6
to
2ba5643
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests on this file are not actually working. There is one mock that have difficulties to be taken into account (registerrequest
) ... The correct behavior is that this method will be called and should return 401 Matrix error (if not UIA action), and then show the different component of the registration. However, the mock written for it is bypassed and I couln't figure it out yet.
I am still leaving it like this, because the other part should be correct, and if one day i have the illumination to solve it, it will be here :D
2556226
to
5e3f865
Compare
5e3f865
to
c42be00
Compare
fixes #1094
Changes
New welcome page
new email check page
New feature flag to activate the view of this flow or not :
Checklist
public
/exported
symbols have accurate TSDoc documentation.