Why remove anchor link extraction? #24
Comments
aepfli
added a commit
to aepfli/markdown-link-extractor
that referenced
this issue
Jan 11, 2023
Anchor detection got removed during refactoring, as a link will still point to a sufficient url with a broken anchor, it still generates wrong/broken links. Especially when markdown is used to generate pages which are checked with tools like HTMLtest, which do verify proper anchors etc. Therefore i reintroduce this change with this pr, but as a configurable option. This should still allow the proper outcome of the refactoring, but ensures backwards compatibility for other users who rely on proper anchor handling. Relates: tcort#24 Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
|
I experienced this issue and stumbled upon this ticket. I am also unsure why it got removed, but I see failing tests with HTMLtest due to this "bug." Therefore I created a proposal pr - maybe it suits both sides. |
aepfli
added a commit
to aepfli/markdown-link-extractor
that referenced
this issue
Jan 11, 2023
Anchor detection got removed during refactoring, as a link will still point to a sufficient url with a broken anchor, it still generates wrong/broken links. Especially when markdown is used to generate pages which are checked with tools like HTMLtest, which do verify proper anchors etc. Therefore i reintroduce this change with this pr, but as a configurable option. This should still allow the proper outcome of the refactoring, but ensures backwards compatibility for other users who rely on proper anchor handling. Relates: tcort#24 Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
added a commit
to aepfli/markdown-link-extractor
that referenced
this issue
Jan 11, 2023
Anchor detection got removed during refactoring, as a link will still point to a sufficient url with a broken anchor, it still generates wrong/broken links. Especially when markdown is used to generate pages which are checked with tools like HTMLtest, which do verify proper anchors etc. Therefore i reintroduce this change with this pr, but as a configurable option. This should still allow the proper outcome of the refactoring, but ensures backwards compatibility for other users who rely on proper anchor handling. Relates: tcort#24 Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
|
tcort/markdown-link-check#212 is also related |
|
@tcort should I keep my pr open, or should I close it? |
|
PR Merged |
|
Reverted. The changes don't work with the latest |
Do you have some more details? Unit tests does not failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It causes a bug in markdown-link-check.
The text was updated successfully, but these errors were encountered: