Feat [#360] 3차 스프린트 건의사항 반영 #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaentopia
approved these changes
Mar 7, 2024
| let startOfToday = calendar.startOfDay(for: currentDate) | ||
| let startOfTappedDate = calendar.startOfDay(for: date) | ||
|
|
||
| return calendar.dateComponents([.day], from: startOfTappedDate, to: startOfToday).day ?? 0 > 0 |
There was a problem hiding this comment.
여기서 혹시 0>0은 bool 값으로 보내주는 건가요?
혹시 그냥 false로 설정하지 않은 이유가 있을까요?
There was a problem hiding this comment.
(day ?? 0 ) > 0 으로 봐주시면 될 것 같습니다 !!
Zoe0929
approved these changes
Mar 8, 2024
| @@ -96,13 +96,19 @@ extension NotificationView { | |||
| isTapped.toggle() | |||
| doNotSeeAgainButton.setImage(UIImage(imageLiteralResourceName: isTapped ? "btnCheckBox" : "btnNotCheckBox"), for: .normal) | |||
| UserDefaults.standard.set(isTapped, forKey: "isTapped") | |||
| if isTapped { | |||
| UserDefaults.standard.set(Date(), forKey: "whenTapped") | |||
There was a problem hiding this comment.
P5. 진짜진짜 의견인데 whenTapped 보다는 TapDate와 같이 명사 형태가 좋을 것 같습니다! isTapped는 bool형이라 변수명이 저 형태였던 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛏ 작업 내용
📌 PR Point!
📸 스크린샷
✅ Issue
Resolved #360