Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat [#369] 상점 뷰 변경 UI 적용 #370

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Feat [#369] 상점 뷰 변경 UI 적용 #370

merged 4 commits into from
Apr 11, 2024

Conversation

Zoe0929
Copy link
Member

@Zoe0929 Zoe0929 commented Apr 10, 2024

⛏ 작업 내용

  • 열람권 1개의 가격이 변경됨에 따라 UI 변경을 진행했습니다.

📌 PR Point!

  • adjustedHeight을 이용했을 경우 iPhone 15 Pro에서 의도치 않게 버튼 길이가 너무 길게 만들어지는 현상을 발견하여 .adjusted로 수정했습니다. 때문에 열쇠 이미지의 크기가 변화되는데 디자인과 논의 완료했습니다!
  • isNonSale이라는 트리거를 추가하여 할인 라벨의 유무를 결정할 수 있도록 수정했습니다.

📸 스크린샷

구현 내용 스크린샷
상점뷰 (SE)
상점뷰 (15Pro)

✅ Issue

Resolved #369

@Zoe0929 Zoe0929 added feat🪄 기능 구현 지희🐰 labels Apr 10, 2024
@Zoe0929 Zoe0929 self-assigned this Apr 10, 2024
@Zoe0929 Zoe0929 linked an issue Apr 10, 2024 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@chaentopia chaentopia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P5
확인했습니다! 할인 태그 처리 감사합니당.
업로드 할 때 금액대 바뀌는 부분은 심사 완료 후 앱스토어 커넥트에서 처리 하겠습니다!

Copy link
Contributor

@Heyjooo Heyjooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P5
수고하셨습니다 !!!

@Zoe0929 Zoe0929 merged commit a27ba8f into develop Apr 11, 2024
@Zoe0929 Zoe0929 changed the title Feat/#369/shop Feat [#369] 상점 뷰 변경 UI 적용 Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feat] 열람권 가격 변경
3 participants