Fix contenteditable child content set with firefox/geckodriver

teamcapybara · Feb 12, 2018 · 34b41ca · 34b41ca
1 parent 263e860
commit 34b41ca
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/History.md b/History.md
@@ -1,11 +1,14 @@
 #Version 2.18.0
 Release date: unreleased
 
+### Fixed
+
+* Firefox/geckodriver setting of contenteditable childs contents
+
 ### Removed
 
 * Headless chrome modal JS injection that is no longer needed for Chrome 64+/chromedriver 2.35+
 
-
 # Version 2.17.0
 Release date: 2018-01-02
 

diff --git a/lib/capybara/selenium/node.rb b/lib/capybara/selenium/node.rb
@@ -78,7 +78,7 @@ def set(value, options={})
         JS
         driver.execute_script script, self
 
-        if (driver.chrome?) || (driver.firefox? && !driver.marionette?)
+        if driver.chrome? || driver.firefox?
           # chromedriver raises a can't focus element for child elements if we use native.send_keys
           # we've already focused it so just use action api
           driver.browser.action.send_keys(value.to_s).perform