Fix xpath indexing to 1-based and support adding attribute which does not exist in existing dom #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technogeek00
added a commit
that referenced
this pull request
Nov 11, 2020
- Full support for DASH specified xpath restrictions - Support for add/replace/delete operations in patch - Validation of Patch on receive - Handling of empty Patch semantics This commit is rebased first pass on to latest dash.js, includes the additional fixes previously provided: - Patch operation ironing fix (#1) - @thmatuza - Xpath indexing and add attribute operation (#2) - @chanyk-joseph
technogeek00
added a commit
that referenced
this pull request
Nov 11, 2020
- Full support for DASH specified xpath restrictions - Support for add/replace/delete operations in patch - Validation of Patch on receive - Handling of empty Patch semantics This commit is rebased first pass on to latest dash.js, includes the additional fixes previously provided: - Patch operation ironing fix (#1) - @thmatuza - Xpath indexing and add attribute operation (#2) - @chanyk-joseph
technogeek00
added a commit
that referenced
this pull request
Nov 12, 2020
- Full support for DASH specified xpath restrictions - Support for add/replace/delete operations in patch - Validation of Patch on receive - Handling of empty Patch semantics This commit is rebased first pass on to latest dash.js, includes the additional fixes previously provided: - Patch operation ironing fix (#1) - @thmatuza - Xpath indexing and add attribute operation (#2) - @chanyk-joseph
|
I've fully pulled the implementation up to date to the tip of dashif/development and incorporated this change directly in the commit. I'll close this PR out and shutdown this old branch. |
technogeek00
added a commit
that referenced
this pull request
Feb 19, 2021
…stry-Forum#3451) * Implementation of MPEG-DASH 5th Edition Patching Semantics - Full support for DASH specified xpath restrictions - Support for add/replace/delete operations in patch - Validation of Patch on receive - Handling of empty Patch semantics This commit is rebased first pass on to latest dash.js, includes the additional fixes previously provided: - Patch operation ironing fix (#1) - @thmatuza - Xpath indexing and add attribute operation (#2) - @chanyk-joseph * Addressing PR Feedback * Add missing additional test case Co-authored-by: Daniel Silhavy <daniel.silhavy@fokus.fraunhofer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AdaptationSet[2] refers to 2nd element, i.e. index 1 in 0-based indexing
https://tools.ietf.org/html/rfc5261#section-4.3.2