This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
feat: working Content Security Policy #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately they rely on new Function() which requires us to allow unsafe-eval
Needed for Next.js
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/technologiestiftung/stadtpuls-frontend/6rZZF3EmiS4b7yk7KxripRDmjXww |
vogelino
approved these changes
Jul 15, 2021
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a working Content Security Policy (the first, already merged attempt was unsuccessful).
The policy should now satisfy all requirements of our code and of 3rd party code. Note that especially Mapbox GL JS requires some pretty lax settings. The library uses
new Function()which is a violation ofunsafe-eval. For now we have to live with allowingunsafe-evalbecause that piece of code has long been in Mapbox GL JSs codebase and will probably not be refactored. Interestingly the use ofunsafe-evalis not covered in their CSP docs.Hint: When reviewing, check the Response Headers in the dev tools Network tab to see the CSP in action.