feat: syntax highlighting using chroma #1
Conversation
elianiva
commented
Oct 5, 2021
elianiva
commented
| highlighted, err := h.Highlight(content, qs.Language, qs.Theme, qs.LineNr) | ||
| if err != nil { | ||
| // they should still be able to get the plain text even if the highlighter is b0rked | ||
| c.Status(http.StatusOK).Send([]byte(content)) |
There was a problem hiding this comment.
if it's error, just return err, no need to make a StatusOK response
There was a problem hiding this comment.
kalo highlighternya doang yg error, masa ga ditampilin meskipun ga pake highlight?
There was a problem hiding this comment.
kemungkinan highlighternya error gara-gara apa?
There was a problem hiding this comment.
gagal tokenise atau formatter gagal ngehasilin output
There was a problem hiding this comment.
oke. tetep aja ga ideal. tapi aku benerin nantian
| @@ -58,13 +58,18 @@ func (d *Dependency) Get(c *fiber.Ctx) error { | |||
| // we need to replace escaped newline to literal newline | |||
| content := strings.Replace(i.Paste, `\n`, "\n", -1) | |||
|
|
|||
| c.Set("Content-Type", "text/plain") | |||
There was a problem hiding this comment.
the Content-Type headers will be set twice when qs.Language is not empty if you put it here
There was a problem hiding this comment.
alasan kenapa ditaruh disini relate sama ini #1 (comment), awalnya biar ga perlu copas, yowes lah
