Skip to content

Commit

Permalink
Fix examples yaml that were not valid
Browse files Browse the repository at this point in the history
Now that the webhook disallow unknown fields, some examples fails
where they didn't before — which is a good thing.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
  • Loading branch information
vdemeester committed Jul 16, 2019
1 parent 44d5041 commit d229fb2
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 16 deletions.
2 changes: 0 additions & 2 deletions examples/pipelineruns/clustertask-pipelinerun.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,4 @@ metadata:
spec:
pipelineRef:
name: sample-pipeline-cluster-task-4
trigger:
type: manual
serviceAccount: 'default'
6 changes: 3 additions & 3 deletions examples/pipelineruns/pipelinerun.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@ spec:
description: Okay this is a hack, but I didn't feel right hard-codeing `-d1` down below
- name: yamlPathToImage
description: The path to the image to replace in the yaml manifest (arg to yq)
clusters:
- name: targetCluster
description: Not yet used, kubectl command below should use this cluster
#clusters:
#- name: targetCluster
# description: Not yet used, kubectl command below should use this cluster
steps:
- name: replace-image
image: mikefarah/yq
Expand Down
8 changes: 4 additions & 4 deletions examples/taskruns/gcs-resource-spec-taskrun.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ metadata:
name: list-file
spec:
taskSpec:
inputs:
resources:
- name: workspace
type: storage
inputs:
resources:
- name: rules
type: storage
steps:
- name: list
image: ubuntu
Expand Down
10 changes: 5 additions & 5 deletions examples/taskruns/git-resource-spec-taskrun.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ metadata:
name: read-file
spec:
taskSpec:
inputs:
resources:
- name: workspace
type: git
targetPath: skaffold
inputs:
resources:
- name: workspace
type: git
targetPath: skaffold
steps:
- name: read
image: ubuntu
Expand Down
2 changes: 0 additions & 2 deletions examples/taskruns/task-multiple-output-image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ metadata:
spec:
taskRef:
name: multiple-build-push-kaniko
trigger:
type: manual
inputs:
resources:
- name: sourcerepo
Expand Down

0 comments on commit d229fb2

Please sign in to comment.