Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TestGetStatuses by sorting slices before comparing them #1072

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Jul 12, 2019

Changes

Fix flaky TestGetStatuses by sorting slices before comparing them.

This should also help fix some of the flakiness with the integration tests because one of the YAML tasks clones and runs unit tests for the pipeline repo in a taskrun e.g. https://tekton-releases.appspot.com/build/tekton-prow/pr-logs/pull/tektoncd_pipeline/1071/pull-tekton-pipeline-integration-tests/1149698811799539712/

Fixes #1049

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jul 12, 2019
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2019
@dibyom
Copy link
Member Author

dibyom commented Jul 12, 2019

/test pull-tekton-pipeline-integration-tests

@ghost
Copy link

ghost commented Jul 12, 2019

/lgtm

@tekton-robot tekton-robot assigned ghost Jul 12, 2019
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2019
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you :)
I've hit the same issue on the CloudEventPipelineResource and had the same solution with sorting.

@dibyom
Copy link
Member Author

dibyom commented Jul 12, 2019

/retest

@bobcatfish
Copy link
Collaborator

Awesome find @dibyom !!! Thank you 😻

/lgtm
/approve
/meow space

@tekton-robot
Copy link
Collaborator

@bobcatfish: cat image

In response to this:

Awesome find @dibyom !!! Thank you 😻

/lgtm
/approve
/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, bobcatfish, dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2019
@tekton-robot tekton-robot merged commit e197459 into tektoncd:master Jul 12, 2019
@dibyom dibyom deleted the flaky_test branch July 12, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd/pullrequest-init/github_test's TestGetStatuses is flaky due to ordering
5 participants