-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow unknown fields from resources struct #1081
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,4 @@ metadata: | |
spec: | ||
pipelineRef: | ||
name: sample-pipeline-cluster-task-4 | ||
trigger: | ||
type: manual | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤦♀ |
||
serviceAccount: 'default' |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -123,9 +123,9 @@ spec: | |
description: Okay this is a hack, but I didn't feel right hard-codeing `-d1` down below | ||
- name: yamlPathToImage | ||
description: The path to the image to replace in the yaml manifest (arg to yq) | ||
clusters: | ||
- name: targetCluster | ||
description: Not yet used, kubectl command below should use this cluster | ||
#clusters: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wasn't sure where this comes from. I am guessing we should remove this altogether most likely 👼 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh wow! yeah feel free to remove it, this is leftover from a really old version of the spec XD There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. forgot to update before removing the hold 😅 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you perhaps have a test, which actually validates this behavior. Would feel better when not only the happy-paths are tested. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @abergmeier yes, working on it (once I land somewhere 🤭) |
||
#- name: targetCluster | ||
# description: Not yet used, kubectl command below should use this cluster | ||
steps: | ||
- name: replace-image | ||
image: mikefarah/yq | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own curiosity: is this a feature that got added somewhere recently, or something we could have been using all along?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and p.s. if it's not new, do you happen to know why ppl looking at this issue before thought we couldn't easily fix it? (#297 (comment))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was added with knative/pkg#338, so ~4month ago 😉