Add a warning when the same resource is used as an input and an output. #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the future, we will be changing the behavior of this. Outputs will always be copied from the /workspace/outputs directory, rather than sometimes copying them from the input.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
googlebot
added
the
cla: yes
tekton-robot
added
approved
|
The following is the coverage report on pkg/.
|
|
It's happening!! 🎉 /lgtm |
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Jul 24, 2019
…esources. This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Jul 24, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
3 tasks
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Jul 24, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Jul 24, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Jul 29, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Jul 29, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Jul 29, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Jul 31, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Jul 31, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Jul 31, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Jul 31, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Aug 5, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Aug 6, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Aug 6, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Aug 8, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Aug 19, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Aug 19, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Aug 19, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Aug 21, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Aug 21, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
bobcatfish
pushed a commit
to dlorenc/build-pipeline
that referenced
this pull request
Sep 12, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to tektoncd#1119 and should be submitted once the next release is cut.
tekton-robot
pushed a commit
that referenced
this pull request
Sep 13, 2019
This change makes the handling of Resources within a Task consistent, regardless of whether the same Resource is used as both an input and an output. Previously these were special cased, which made it hard to write Tasks consistently. This commit also makes a few minor changes to the way our bash output gets logged. I discovered this was missing during debugging, and made it consistent with the gsutil wrapper. This is a followup to #1119 and should be submitted once the next release is cut.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In the future, we will be changing the behavior of this. Outputs will
always be copied from the /workspace/outputs directory, rather than
sometimes copying them from the input.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Release Notes