Update golangci configuration ☕ #2567
Conversation
This removes some flags that are now in the configuration, and add more information. Trying `disable-all` with `enable` to limit the linter run to only the one we specify. Also trying to run less linters on `_test.go`. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
tekton-robot
added
the
size/M
|
/cc @afrittoli @sbwsg |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
| linters-settings: | ||
| errcheck: | ||
| exclude: .errcheck.txt | ||
| linters: | ||
| disable-all: true | ||
| enable: |
There was a problem hiding this comment.
so that's explicitly enable only those following linters, which is i think good, but just making sure that's what you want
afrittoli
added
the
needs-cherry-pick
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
afrittoli
removed
the
needs-cherry-pick
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
Changes
This removes some flags that are now in the configuration, and add
more information. Trying
disable-allwithenableto limit thelinter run to only the one we specify. Also trying to run less linters
on
_test.go.Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.