Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report metrics from tests #3245

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Report metrics from tests #3245

merged 3 commits into from
Jul 20, 2023

Conversation

josecv
Copy link
Member

@josecv josecv commented Jun 20, 2023

Description

This introduces a new test-report tool that can consume json output from
tests and report it to metriton. When running in CI, this reporting is
enabled. It's disabled when running tests locally. With reporting
disabled, test-report just shows a UI reporting on test progress to the
user.

Checklist

  • I made sure to update ./CHANGELOG.yml.
  • I made sure to add any docs changes required for my change (including release notes).
  • My change is adequately tested.
  • I updated DEVELOPING.md with any special dev tricks I had to use to work on this code efficiently.
  • I updated TELEMETRY.md if I added, changed, or removed a metric name.
  • Once my PR is ready to have integration tests ran, I posted the PR in #telepresence-dev in the datawire-oss slack so that the "ok to test" label can be applied.

@josecv josecv force-pushed the josecv/display-tests branch 17 times, most recently from 9e17ce9 to 9e00b19 Compare June 26, 2023 17:42
@josecv josecv changed the title tests metrics Report metrics from tests Jun 26, 2023
@josecv josecv force-pushed the josecv/display-tests branch 2 times, most recently from d5d1327 to 8584d6b Compare June 26, 2023 17:45
@josecv josecv added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Jun 26, 2023
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Jun 26, 2023
@josecv josecv marked this pull request as ready for review June 26, 2023 18:42
@josecv josecv requested review from a team, shepz and knlambert and removed request for a team and shepz June 26, 2023 18:43
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Jun 27, 2023
@josecv josecv requested review from a team and njayp and removed request for a team June 27, 2023 15:45
@josecv josecv added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Jun 27, 2023
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Jun 27, 2023
@josecv josecv added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Jun 27, 2023
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Jun 27, 2023
@josecv josecv added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Jun 27, 2023
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Jun 27, 2023
@josecv josecv added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Jun 27, 2023
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Jun 27, 2023
Copy link
Member

@thallgren thallgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add commit and PR comments that explain what this is all about. An entry in DEVELOPMENT.md would be welcome too, explaining how to use the new tool.

@josecv josecv requested a review from thallgren July 18, 2023 14:56
@josecv josecv added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Jul 18, 2023
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Jul 18, 2023
This introduces a new test-report tool that can consume json output from
tests and report it to metriton. When running in CI, this reporting is
enabled. It's disabled when running tests locally. With reporting
disabled, test-report just shows a UI reporting on test progress to the
user.

Signed-off-by: Jose Cortes <josecortes@datawire.io>
Signed-off-by: Jose Cortes <josecortes@datawire.io>
Signed-off-by: Jose Cortes <josecortes@datawire.io>
@josecv josecv added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Jul 19, 2023
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Jul 19, 2023
@josecv josecv merged commit 494788b into release/v2 Jul 20, 2023
13 checks passed
@josecv josecv deleted the josecv/display-tests branch July 20, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants