-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report metrics from tests #3245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecv
force-pushed
the
josecv/display-tests
branch
17 times, most recently
from
June 26, 2023 17:42
9e17ce9
to
9e00b19
Compare
josecv
force-pushed
the
josecv/display-tests
branch
2 times, most recently
from
June 26, 2023 17:45
d5d1327
to
8584d6b
Compare
josecv
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jun 26, 2023
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jun 26, 2023
josecv
requested review from
a team,
shepz and
knlambert
and removed request for
a team and
shepz
June 26, 2023 18:43
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jun 27, 2023
josecv
force-pushed
the
josecv/display-tests
branch
from
June 27, 2023 15:57
19f9f13
to
367ddab
Compare
josecv
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jun 27, 2023
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jun 27, 2023
josecv
force-pushed
the
josecv/display-tests
branch
from
June 27, 2023 16:13
367ddab
to
29a846b
Compare
josecv
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jun 27, 2023
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jun 27, 2023
josecv
force-pushed
the
josecv/display-tests
branch
from
June 27, 2023 16:17
29a846b
to
89cd4b8
Compare
josecv
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jun 27, 2023
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jun 27, 2023
josecv
force-pushed
the
josecv/display-tests
branch
from
June 27, 2023 16:53
89cd4b8
to
ad4088b
Compare
josecv
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jun 27, 2023
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jun 27, 2023
thallgren
requested changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add commit and PR comments that explain what this is all about. An entry in DEVELOPMENT.md would be welcome too, explaining how to use the new tool.
josecv
force-pushed
the
josecv/display-tests
branch
from
July 18, 2023 14:34
ad4088b
to
0623865
Compare
josecv
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jul 18, 2023
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jul 18, 2023
thallgren
approved these changes
Jul 18, 2023
This introduces a new test-report tool that can consume json output from tests and report it to metriton. When running in CI, this reporting is enabled. It's disabled when running tests locally. With reporting disabled, test-report just shows a UI reporting on test progress to the user. Signed-off-by: Jose Cortes <josecortes@datawire.io>
Signed-off-by: Jose Cortes <josecortes@datawire.io>
Signed-off-by: Jose Cortes <josecortes@datawire.io>
josecv
force-pushed
the
josecv/display-tests
branch
from
July 19, 2023 14:32
6ddbf54
to
2ec6565
Compare
josecv
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jul 19, 2023
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces a new test-report tool that can consume json output from
tests and report it to metriton. When running in CI, this reporting is
enabled. It's disabled when running tests locally. With reporting
disabled, test-report just shows a UI reporting on test progress to the
user.
Checklist
./CHANGELOG.yml
.DEVELOPING.md
with any special dev tricks I had to use to work on this code efficiently.TELEMETRY.md
if I added, changed, or removed a metric name.