Skip to content

Commit

Permalink
cleanup: fix undeclared and incorrect BUILD deps (#3641)
Browse files Browse the repository at this point in the history 
* update `*_plugin_notf_test` target deps to match `*_plugin_test` deps

Generated mechanically by the following (note that for graphs, we special case and
copy from graphs_plugin_test_lib rather than graphs_plugin_test):

```
buildozer 'copy deps audio_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/audio:audio_plugin_notf_test
buildozer 'copy deps custom_scalars_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/custom_scalar:custom_scalars_plugin_notf_test
buildozer 'copy deps distributions_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/distribution:distributions_plugin_notf_test
buildozer 'copy deps graphs_plugin_test_lib' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/graph:graphs_plugin_notf_test
buildozer 'copy deps histograms_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/histogram:histograms_plugin_notf_test
buildozer 'copy deps images_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/image:images_plugin_notf_test
buildozer 'copy deps pr_curves_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/pr_curve:pr_curves_plugin_notf_test
buildozer 'copy deps projector_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/projector:projector_plugin_notf_test
buildozer 'copy deps scalars_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/scalar:scalars_plugin_notf_test
buildozer 'copy deps text_plugin_test' 'add deps //tensorboard/compat:no_tensorflow' //tensorboard/plugins/text:text_plugin_notf_test
```

* add missing deps inherited transitively through application
  • Loading branch information
@nfelt @caisq
nfelt authored and caisq committed May 27, 2020
1 parent f7271b5 commit 84eb921
Show file tree
Hide file tree
Showing 10 changed files with 25 additions and 3 deletions.
1 change: 1 addition & 0 deletions tensorboard/plugins/audio/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ py_test(
"//tensorboard:expect_numpy_installed",
"//tensorboard:expect_tensorflow_installed",
"//tensorboard/backend:application",
"//tensorboard/backend/event_processing:data_provider",
"//tensorboard/backend/event_processing:event_multiplexer",
"//tensorboard/compat:no_tensorflow",
"//tensorboard/plugins:base_plugin",
Expand Down
1 change: 1 addition & 0 deletions tensorboard/plugins/core/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ py_test(
"//tensorboard/backend:application",
"//tensorboard/backend/event_processing:event_multiplexer",
"//tensorboard/compat/proto:protos_all_py_pb2",
"//tensorboard/data:provider",
"//tensorboard/plugins:base_plugin",
"//tensorboard/util:test_util",
"@org_pocoo_werkzeug",
Expand Down
3 changes: 3 additions & 0 deletions tensorboard/plugins/custom_scalar/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ py_test(
"//tensorboard:expect_numpy_installed",
"//tensorboard:expect_tensorflow_installed",
"//tensorboard/backend:application",
"//tensorboard/backend/event_processing:event_multiplexer",
"//tensorboard/util:tensor_util",
"//tensorboard/util:test_util",
],
Expand All @@ -79,6 +80,7 @@ py_test(
"//tensorboard:expect_numpy_installed",
"//tensorboard:expect_tensorflow_installed",
"//tensorboard/backend:application",
"//tensorboard/backend/event_processing:event_multiplexer",
"//tensorboard/plugins:base_plugin",
"//tensorboard/plugins/scalar:scalars_plugin",
"//tensorboard/plugins/scalar:summary",
Expand All @@ -100,6 +102,7 @@ py_test(
"//tensorboard:expect_numpy_installed",
"//tensorboard:expect_tensorflow_installed",
"//tensorboard/backend:application",
"//tensorboard/backend/event_processing:event_multiplexer",
"//tensorboard/compat:no_tensorflow",
"//tensorboard/plugins:base_plugin",
"//tensorboard/plugins/scalar:scalars_plugin",
Expand Down
1 change: 1 addition & 0 deletions tensorboard/plugins/distribution/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ py_test(
deps = [
":compressor",
":distributions_plugin",
"//tensorboard:errors",
"//tensorboard:expect_tensorflow_installed",
"//tensorboard/backend:application",
"//tensorboard/backend/event_processing:event_multiplexer",
Expand Down
2 changes: 2 additions & 0 deletions tensorboard/plugins/graph/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,13 @@ py_test(
":graphs_plugin",
"//tensorboard:expect_tensorflow_installed",
"//tensorboard/backend:application",
"//tensorboard/backend/event_processing:data_provider",
"//tensorboard/backend/event_processing:event_multiplexer",
"//tensorboard/compat:no_tensorflow",
"//tensorboard/compat/proto:protos_all_py_pb2",
"//tensorboard/plugins:base_plugin",
"//tensorboard/util:test_util",
"@com_google_protobuf//:protobuf_python",
"@org_pocoo_werkzeug",
"@org_pythonhosted_six",
],
Expand Down
4 changes: 3 additions & 1 deletion tensorboard/plugins/histogram/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,13 @@ py_test(
deps = [
":histograms_plugin",
":summary",
"//tensorboard:errors",
"//tensorboard:expect_tensorflow_installed",
"//tensorboard/backend:application",
"//tensorboard/backend/event_processing:event_accumulator",
"//tensorboard/backend/event_processing:event_multiplexer",
"//tensorboard/backend/event_processing:tag_types",
"//tensorboard/compat:no_tensorflow",
"//tensorboard/data:provider",
"//tensorboard/plugins:base_plugin",
"//tensorboard/util:test_util",
"@org_pocoo_werkzeug",
Expand Down
5 changes: 4 additions & 1 deletion tensorboard/plugins/pr_curve/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ py_test(
"//tensorboard:expect_numpy_installed",
"//tensorboard:expect_tensorflow_installed",
"//tensorboard/backend:application",
"//tensorboard/backend/event_processing:data_provider_test",
"//tensorboard/backend/event_processing:data_provider",
"//tensorboard/backend/event_processing:event_multiplexer",
"//tensorboard/plugins:base_plugin",
"@org_pocoo_werkzeug",
"@org_pythonhosted_six",
Expand All @@ -70,6 +71,8 @@ py_test(
"//tensorboard:expect_numpy_installed",
"//tensorboard:expect_tensorflow_installed",
"//tensorboard/backend:application",
"//tensorboard/backend/event_processing:data_provider",
"//tensorboard/backend/event_processing:event_multiplexer",
"//tensorboard/compat:no_tensorflow",
"//tensorboard/plugins:base_plugin",
"@org_pocoo_werkzeug",
Expand Down
1 change: 1 addition & 0 deletions tensorboard/plugins/projector/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ py_test(
"//tensorboard/backend:application",
"//tensorboard/backend/event_processing:event_multiplexer",
"//tensorboard/compat:no_tensorflow",
"//tensorboard/compat/proto:protos_all_py_pb2",
"//tensorboard/plugins:base_plugin",
"//tensorboard/util:test_util",
"@org_pocoo_werkzeug",
Expand Down
9 changes: 8 additions & 1 deletion tensorboard/plugins/scalar/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ py_test(
"//tensorboard:errors",
"//tensorboard:expect_tensorflow_installed",
"//tensorboard/backend:application",
"//tensorboard/backend/event_processing:data_provider",
"//tensorboard/backend/event_processing:event_multiplexer",
"//tensorboard/backend/event_processing:tag_types",
"//tensorboard/compat/proto:protos_all_py_pb2",
"//tensorboard/plugins:base_plugin",
Expand All @@ -57,12 +59,17 @@ py_test(
main = "scalars_plugin_test.py",
srcs_version = "PY2AND3",
deps = [
":metadata",
":scalars_plugin",
":summary",
"//tensorboard:errors",
"//tensorboard:expect_tensorflow_installed",
"//tensorboard/backend:application",
"//tensorboard/backend/event_processing:event_accumulator",
"//tensorboard/backend/event_processing:data_provider",
"//tensorboard/backend/event_processing:event_multiplexer",
"//tensorboard/backend/event_processing:tag_types",
"//tensorboard/compat:no_tensorflow",
"//tensorboard/compat/proto:protos_all_py_pb2",
"//tensorboard/plugins:base_plugin",
"//tensorboard/util:test_util",
"@org_pocoo_werkzeug",
Expand Down
1 change: 1 addition & 0 deletions tensorboard/plugins/text/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ py_test(
"//tensorboard:expect_tensorflow_installed",
"//tensorboard:plugin_util",
"//tensorboard/backend:application",
"//tensorboard/backend/event_processing:data_provider",
"//tensorboard/backend/event_processing:event_multiplexer",
"//tensorboard/compat:no_tensorflow",
"//tensorboard/plugins:base_plugin",
Expand Down

0 comments on commit 84eb921

Please sign in to comment.