Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pip install tf-nightly within .travis.yml #852

Merged
merged 1 commit into from
Jan 6, 2018

Conversation

chihuahua
Copy link
Member

@chihuahua chihuahua commented Jan 3, 2018

The security certificate of ci.tensorflow.org expired, causing TensorBoard's tests on travis to fail. See tensorflow/tensorflow#15827.

This change enables our travis environment to successfully install tf-nightly.

Unfortunately, the travis tests still fail after this PR goes in, but that is because of tensorflow/tensorflow#15777. We are still deciding what to do there - we might have to dockerize tests.

Anyways, fixing the issue caused by the expired certificate will let us focus on that different issue. Thanks to @nfelt for suggesting that we try using pip install tf-nightly.

instead of pip installing the nightly whl URLs.
@chihuahua chihuahua changed the title Test out using wget to bypass request module Test out using pip install tf-nightly Jan 4, 2018
@nfelt
Copy link
Contributor

nfelt commented Jan 4, 2018

Well it looks like that helped, but now some tests are failing on a missing GLIBCXX_3.4.20. It sounds like that might be because we're using trusty (14.04) for Travis but apparently TensorFlow builds are on 16.04 and hence only support GLIBCXX versions from what 16.04 ships with on up: ContinuumIO/anaconda-issues#483 (comment)

And I guess Travis has no real plans to support 16.04 Ubuntu, or for that matter anything beyond 14.04, ugh: travis-ci/travis-ci#5821

So... maybe there's a way we can install a newer glibcxx on the machine prior to running our tests?

@chihuahua
Copy link
Member Author

The folks who reported tensorflow/tensorflow#15777 ended up dockerizing their tests: horovod/horovod#136 ...

@chihuahua chihuahua requested review from jart and nfelt January 5, 2018 04:49
@chihuahua chihuahua changed the title Test out using pip install tf-nightly Use pip install tf-nightly within travis.yml Jan 5, 2018
@chihuahua chihuahua changed the title Use pip install tf-nightly within travis.yml Use pip install tf-nightly within .travis.yml Jan 5, 2018
@chihuahua chihuahua merged commit 936e573 into tensorflow:master Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants