cmake: restrict the config path change to unix #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an attempt to minimize backward compatibility concerns to the config path change introduced early, change it so it only applies to UNIX systems, where it improves multiarch compatibility and as a sideeffect keep the old path, more commonly used by Windows in that platform.
carenas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assuming the change introduced with PCRE2Project@2410fbe by jwsblokland is being used and not a bug.
one advantage I see of using the "legacy" path in Windows is that it would allow a single installation of PCRE2 to be used by both MSVC and MinGW projects.