Fix ineffassign issues & add it to CI (#156)

Signed-off-by: Igor Shishkin <me@teran.dev>

.github/workflows/release.yml

@@ -44,6 +44,19 @@ jobs:
       - uses: actions/checkout@v4
       - uses: articulate/actions-markdownlint@v1
 
+  ineffassign:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Setup Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: '1.23.x'
+      - name: Install ineffassign
+        run: go install github.com/gordonklaus/ineffassign@latest
+      - name: Run ineffassign
+        run: ineffassign ./...
+
   unittests:
     runs-on: ubuntu-latest
     steps:

.github/workflows/verify.yml

@@ -50,6 +50,19 @@ jobs:
       - uses: actions/checkout@v4
       - uses: articulate/actions-markdownlint@v1
 
+  ineffassign:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Setup Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: '1.23.x'
+      - name: Install ineffassign
+        run: go install github.com/gordonklaus/ineffassign@latest
+      - name: Run ineffassign
+        run: ineffassign ./...
+
   unittests:
     runs-on: ubuntu-latest
     steps:

cmd/manager/main.go

@@ -88,6 +88,9 @@ func main() {
 			cfg.BLOBS3AccessKeyID, cfg.BLOBS3SecretKey, "",
 		),
 	})
+	if err != nil {
+		panic(err)
+	}
 
 	s3client := s3.New(awsSession)
 

cmd/publisher/main.go

@@ -113,6 +113,9 @@ func main() {
 			cfg.BLOBS3AccessKeyID, cfg.BLOBS3SecretKey, "",
 		),
 	})
+	if err != nil {
+		panic(err)
+	}
 
 	blobRepo := awsBlobRepo.New(s3.New(awsSession), cfg.BLOBS3Bucket, cfg.BLOBS3PresignedLinkTTL)
 

gc/service/service.go

@@ -65,8 +65,8 @@ func (s *service) Run(ctx context.Context) error {
 			}
 
 			var (
-				total  uint64 = 0
-				offset uint64 = 0
+				total  uint64
+				offset uint64
 			)
 
 			for {
@@ -77,8 +77,7 @@ func (s *service) Run(ctx context.Context) error {
 					"limit":     defaultLimit,
 				}).Tracef("list objects loop iteration ...")
 
-				var objects []string = []string{}
-
+				var objects []string
 				total, objects, err = s.cfg.MdRepo.ListObjects(ctx, container, version.Name, offset, defaultLimit)
 				if err != nil {
 					return errors.Wrapf(err, "error listing objects for container `%s`; version `%s`", container, version.Name)

repositories/metadata/postgresql/stats.go

@@ -96,6 +96,9 @@ func (r *repository) CountStats(ctx context.Context) (*models.Stats, error) {
 		GroupBy("c.name", "v.name", "v.is_published").
 		OrderBy("c.name", "v.name", "v.is_published"),
 	)
+	if err != nil {
+		return nil, err
+	}
 
 	for rows.Next() {
 		brsb := models.BlobsRawSizeBytes{}