delete unused dict entries in a squash #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR got a bit bigger than it was originally. Besides unused dict deletions, there's also a whole bunch of memory optimizations in here now, mostly around pre-allocating squash buffers so that we don't rely on dynamic growth, which regularly overshoots (thus needing more memory than is actually needed), and is also slower since it incurs several buffer moves. There's more that could be done, but since the squash itself is now implemented and tests have been written for it, I think we should merge this first. |
GavinMendelGleason
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the squash refactor I forgot to make sure unused dict entries are deleted. This PR does a use check for all squashed dict entries and removes the ones that are unused.