Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when generating report for some docker images #812

Closed
michellegx111 opened this issue Sep 23, 2020 · 1 comment · Fixed by #813
Closed

Error when generating report for some docker images #812

michellegx111 opened this issue Sep 23, 2020 · 1 comment · Fixed by #813
Labels
bug Something went wrong

Comments

@michellegx111
Copy link

I have tried to run tern in docker to analyse my docker images. For some, it run successfully, but for others it failed with message "ERROR - rootfs - Command failed. /bin/sh: 1: export: 2A684B57436A81FA8706B53C61C3351A438A3B7D: bad variable name
"

Does anyone know why I have such error for some of my docker images? Thanks a lot in advance!

The whole log are in the attachment.
error.txt
@nishakm nishakm added the bug Something went wrong label Sep 23, 2020
@nishakm
Copy link
Contributor

nishakm commented Sep 23, 2020

It looks like our parser is ignoring the tabs in one of the ENV lines:

ENV JETTY_GPG_KEYS \
	# Jan Bartel      <janb@mortbay.com>
	AED5EE6C45D0FE8D5D1B164F27DED4BF6216DB8F \
	# Jesse McConnell <jesse.mcconnell@gmail.com>
	2A684B57436A81FA8706B53C61C3351A438A3B7D \
	# Joakim Erdfelt  <joakim.erdfelt@gmail.com>
	5989BAF76217B843D66BE55B2D0E1FB8FE4B68B4 \
	# Joakim Erdfelt  <joakim@apache.org>
	B59B67FD7904984367F931800818D9D68FB67BAC \
	# Joakim Erdfelt  <joakim@erdfelt.com>
	BFBB21C246D7776836287A48A04E0C74ABB35FEA \
	# Simone Bordet   <simone.bordet@gmail.com>
	8B096546B1A8F02656B15D3B1677D141BCF3584D \
	# Greg Wilkins    <gregw@webtide.com>
	FBA2B18D238AB852DF95745C76157BDF03D0DCD6 \
	# Greg Wilkins    <gregw@webtide.com>
	5C9579B3DB2E506429319AAEF33B071B29559E1E \
	# Olivier Lamy <olamy@apache.org>
	F254B35617DC255D9344BCFA873A8E86B4372146

@ForgetMe17 Do you know of a fix for this?

ForgetMe17 added a commit to ForgetMe17/tern that referenced this issue Sep 25, 2020
@ForgetMe17
Fix error caused by tabs in ENV
32a2618 
This commit replace '\t' with '\\t' in the ENV command. This will allow
'export VAR=VAL' works properly when VAL contains '\t'.

Fixes tern-tools#812.

Signed-off-by: WangJL <hazard15020@gmail.com>
@ForgetMe17 ForgetMe17 mentioned this issue Sep 25, 2020
Merged
ForgetMe17 added a commit to ForgetMe17/tern that referenced this issue Sep 25, 2020
@ForgetMe17
Fix error caused by tabs in ENV
6d75b2e 
This commit replace '\t' with '\\t' in the ENV command. This will allow
'export VAR=VAL' works properly when VAL contains '\t'.

Fixes tern-tools#812.

Signed-off-by: WangJL <hazard15020@gmail.com>
nishakm pushed a commit that referenced this issue Sep 25, 2020
@ForgetMe17
Fix error caused by tabs in ENV
056c309 
This commit replace '\t' with '\\t' in the ENV command. This will allow
'export VAR=VAL' works properly when VAL contains '\t'.

Fixes #812.

Signed-off-by: WangJL <hazard15020@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something went wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error caused by tabs in ENV ForgetMe17/tern
2 participants
@nishakm @michellegx111