machine: StartMachine reimplementation #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This re-implements the Machine.Start as a Manager.StartMachine, which conforms to the new MachineManager interface.
|
@ivocalado do you mind taking a look? the terraform-provider-virtualbox is a very heavy user of this repository so much so that most functionality has to first appear here before we can add anything new or fix anything new in the provider. For context: #40 I am trying to redesign the API of this package so its a bit more testable for us in the provider, hopefully adding more tests as we go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-implements the Machine.Start as a Manager.StartMachine, which conforms
to the new MachineManager interface.