Make the provider more idiomatic #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoyTechnology
force-pushed
the
internal-provider
branch
from
4bbe421
to
6e13945
Compare
The provider was originally written on the old SDK and some of the patterns were not updated. This more closely follows the pattern from hashicorp scaffolding provider. There is no need for the API to be public, hence they are in the internal directory. Also included is a bump in go-virtualbox version to include the new Manager interface which will be called in resources and data sources improving testability of provider.
VoyTechnology
force-pushed
the
internal-provider
branch
from
6e13945
to
7457ef7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provider was originally written on the old SDK and some of the patterns were not updated. This more closely follows the pattern from hashicorp scaffolding provider.
There is no need for the API to be public, hence they are in the internal directory.
Also included is a bump in go-virtualbox version to include the new Manager interface which will be called in resources and data sources improving testability of provider.