Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init builder module account during upgrade #177

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

javiersuweijie
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #177 (4217102) into release/v2.5 (1d3f497) will increase coverage by 1.15%.
Report is 1 commits behind head on release/v2.5.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v2.5     #177      +/-   ##
================================================
+ Coverage         68.85%   70.00%   +1.15%     
================================================
  Files                27       26       -1     
  Lines              1785     1697      -88     
================================================
- Hits               1229     1188      -41     
+ Misses              441      397      -44     
+ Partials            115      112       -3     
Files Coverage Δ
app/app.go 82.41% <100.00%> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

emidev98
emidev98 previously approved these changes Oct 2, 2023
Copy link
Contributor

@emidev98 emidev98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well catch @javiersuweijie !

@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@emidev98
Copy link
Contributor

emidev98 commented Oct 9, 2023

Both SonarCloud and Codecov does similar actions. I would suggest to keep just one of them instead of both, I will proceed to disable SonarCloud. If we feel like needing it in the future we can enable it again.

@tuky191 tuky191 self-requested a review October 9, 2023 08:07
@tuky191 tuky191 merged commit 64783d3 into release/v2.5 Oct 9, 2023
10 of 11 checks passed
@emidev98 emidev98 deleted the fix/uninit-builder-module-acc branch October 9, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants