[WIP] Adding new integration test #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrislovecnm
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
chrislovecnm
force-pushed
the
beta-integration-tests
branch
from
13cf7f5
to
8135cb5
Compare
|
@morgante / @aaron-lane I missed something in this PR since the new integration test is not running in concourse. Any ideas? |
|
@chrislovecnm New tests have to be added to the pipeline config before they get executed. |
|
Well then I need to test more locally. I am guessing with the file being external to this project that it has the capability to mess up testing across multiple PRs and not just this PR. |
chrislovecnm
changed the title
|
@chrislovecnm Nothing should be "messed up" here, what's not working or still WIP? The expected workflow is:
It's not perfect, but it's not terrible and there are some risks with having the pipeline definition editable in PRs. |
This commit adds a new integration test, which tests the beta public module.
chrislovecnm
force-pushed
the
beta-integration-tests
branch
from
8135cb5
to
3ca42a5
Compare
|
@morgante You can probably close this one |
|
Replaced by #219. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new integration test, which tests the beta
public module.
This fixes #180