Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kms): add support of kms key in node config #2006

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johanferguth
Copy link

To avoid the following error

[...].module.gke.google_container_cluster.primary: Creating...
╷
│ Error: googleapi: Error 400: Failed precondition: Constraint `constraints/gcp.restrictNonCmekServices` violated for `projects/427955863992` attempting to create a resource without specifying a KMS CryptoKey.
│ Details:
│ [
│   {
│     "@type": "[type.googleapis.com/google.rpc.RequestInfo](http://type.googleapis.com/google.rpc.RequestInfo)",
│     "requestId": "0x49b9d3b73e2c5556"
│   }
│ ]
│ , failedPrecondition
│
│   with module.environment_cluster.module.cluster.module.gke.google_container_cluster.primary,
│   on .terraform/modules/environment_cluster.cluster.gke/cluster.tf line 22, in resource "google_container_cluster" "primary":
│   22: resource "google_container_cluster" "primary" {
│

Unfortunately cannot have enough rights to properly test end to end

@johanferguth johanferguth requested review from ericyz, gtsorbo and a team as code owners July 24, 2024 15:17
Copy link

google-cla bot commented Jul 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@johanferguth johanferguth force-pushed the chore/add-support-kms-in-node-config branch from c75fd32 to b52f92a Compare August 26, 2024 15:07
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @johanferguth - Please sign the CLA so we can review this contribution.

@johanferguth
Copy link
Author

johanferguth commented Sep 16, 2024

Hello @johanferguth - Please sign the CLA so we can review this contribution.

Hi thanks the message,in fact I changed my position to another company since I have published this Pull Request. My colleague @gaetan-craft or @FrPellissier will deal with the CLA part from now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants