Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter 'registry_project_id' to the GKE module templates #273

Merged
merged 3 commits into from
Oct 18, 2019

Conversation

mmontan
Copy link
Contributor

@mmontan mmontan commented Oct 1, 2019

The PR allows configuring the project holding the GCR registry when
used in connection with 'create_service_account'=true and
grant_registry_access=true.

Holding the GCR is a project with other resources increases the risk of
exposing sensitive data to the service account running the nodes, as the
required permissions of role roles/storage.objectViewer provide access
to all storage objects in the project.

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core change looks fine.

For testing, could we consider adding these tests to an existing suite? GKE tests are unfortunately very long so I'd like to avoid the proliferation of test suites so we don't make integration tests run even longer than they already do.

The PR allows configuring the project holding the GCR registry when
used in connection with 'create_service_account'=true and
grant_registry_access=true.

Holding the GCR is a project with other resources increases the risk of
exposing sensitive data to the service account running the nodes, as the
required permissions of role roles/storage.objectViewer provide access
to all storage objects in the project.
@mmontan
Copy link
Contributor Author

mmontan commented Oct 7, 2019

The Cloud Build check pass now. I can't access logs from the concourse builds, so it's hard to debug them. How do I find the logs?

@morgante
Copy link
Contributor

morgante commented Oct 7, 2019

I can't access logs from the concourse builds, so it's hard to debug them.

You can ignore Concourse tests. They're legacy and no longer needed.

@aaron-lane aaron-lane added the enhancement New feature or request label Oct 9, 2019
@morgante morgante self-assigned this Oct 17, 2019
@morgante morgante merged commit 4815c7a into terraform-google-modules:master Oct 18, 2019
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…cr-project

Add a parameter 'registry_project_id' to the GKE module templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants