Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor highlight/select features in both feature grids #594

Open
hwbllmnn opened this issue Apr 23, 2018 · 3 comments
Open

Refactor highlight/select features in both feature grids #594

hwbllmnn opened this issue Apr 23, 2018 · 3 comments
Labels
enhancement

Comments

@hwbllmnn
Copy link
Member

Both grids currently use setStyle on the original layer in order to highlight and select features. That's an unclean solution which may cause lots of trouble. Instead, separate temporary layers should be used instead.
@hwbllmnn hwbllmnn mentioned this issue Apr 23, 2018
Merged
@dnlkoch
Copy link
Member

dnlkoch commented May 23, 2018

Note: Currently the selection of features is broken in the FeatureGrid.

@marcjansen
Copy link
Member

What is the current state here?

@dnlkoch
Copy link
Member

dnlkoch commented Nov 20, 2018

Selection bug seems to be fixed, but the usage of setStyle is still present and should be fixed.

hblitza pushed a commit that referenced this issue Oct 19, 2022
@dnlkoch
Merge pull request #594 from terrestris/dependabot/npm_and_yarn/babel…
c5f16cc 
…/core-7.16.10

Bump @babel/core from 7.16.7 to 7.16.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcjansen @hwbllmnn @dnlkoch